Re: [PATCH net v3] net: nfc: nci: Add parameter validation for packet data

Simon Horman
2025-09-19T18:52:36Z

On Fri, Sep 19, 2025 at 12:15:44PM +0530, Deepak Sharma wrote:
> Syzbot reported an uninit-value bug at nci_init_req for commit
> 5aca7966d2a7 ("Merge tag 'perf-tools-fixes-for-v6.17-2025-09-16'..).
>
> This bug arises due to very limited and poor input validation
> that was done at nic_valid_size(). This validation only
> validates the skb->len (directly reflects size provided at the
> userspace interface) with the length provided in the buffer
> itself (interpreted as NCI_HEADER). This leads to the processing
> of memory content at the address assuming the correct layout
> per what opcode requires there. This leads to the accesses to
> buffer of `skb_buff->data` which is not assigned anything yet.
>
> Following the same silent drop of packets of invalid sizes at
> `nic_valid_size()`, add validation of the data in the respective
> handlers and return error values in case of failure. Release
> the skb if error values are returned from handlers in
> `nci_nft_packet` and effectively do a silent drop
>
> Possible TODO: because we silently drop the packets, the
> call to `nci_request` will be waiting for completion of request
> and will face timeouts. These timeouts can get excessively logged
> in the dmesg. A proper handling of them may require to export
> `nci_request_cancel` (or propagate error handling from the
> nft packets handlers).
>
> Reported-by: syzbot+740e04c2a93467a0f8c8@syzkaller.appspotmail.com
> Closes: https://syzkaller.appspot.com/bug?extid=740e04c2a93467a0f8c8
> Fixes: 6a2968aaf50c ("NFC: basic NCI protocol implementation)

There is a typo in the fixes tag. It should be:

Fixes: 6a2968aaf50c ("NFC: basic NCI protocol implementation")
^^^
I expect there is no need to repost to address this.

> Tested-by: syzbot+740e04c2a93467a0f8c8@syzkaller.appspotmail.com
> Signed-off-by: Deepak Sharma <deepak.sharma.472935@gmail.com>

...