From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2E84F1853 for ; Sun, 21 Sep 2025 12:33:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758457989; cv=none; b=Ly72g6PzLatvj9s/QopEXL+NKzhyosywhhdwdD8sOxKiTN3nd9O3lQz0oLHRI/309JO4xpffJ/hu2Up66YQjAAMzHTMysrnK4sM5bfGEY2dOy0L7R0wCzy3i3atwtCTZcxgAn4VKjrKvZ9gdedbAc3rFd/+6eyeyYwI8VTJUKk4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758457989; c=relaxed/simple; bh=E6V3R1WnPFE5xlO8RqCVDn2Kw53J4KDrxLMNMaY11WE=; h=Subject:To:Cc:From:Date:Message-ID:MIME-Version:Content-Type; b=FXcgzznvB3jV8pT6OweDxbvJwLNe62j9JM5HICR3ZdhSE4fIrqz9nR3/P11SzTGvrm47SKt6Ofc7ypZb6K+xHx96CNMLfLIOcsyzYqr6gzPnD26dl951XgoDPLOLxxl7jwFNBeb9vhtnMlih94sHKEoYlkQXRuQ2DzomH6GnHHE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=mK0E/UCs; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="mK0E/UCs" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B8B8CC4CEE7; Sun, 21 Sep 2025 12:33:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1758457989; bh=E6V3R1WnPFE5xlO8RqCVDn2Kw53J4KDrxLMNMaY11WE=; h=Subject:To:Cc:From:Date:From; b=mK0E/UCs73mFtKV5I6zXpB0WDDJNNhtBJV+rzlKtlNFY2TiSdYKVjNR3mCNQ+J4vd TkflDXCVPsRSrq21iAE57SCitlqGnms9CKeTiQY9vdTFE2LLSsV8oUAdjOXk4TeG5B C0oP+GHYCfsjzvAJqXYOkes/KH+h+9A3FDuqZRmk= Subject: FAILED: patch "[PATCH] net: rfkill: gpio: Fix crash due to dereferencering" failed to apply to 5.10-stable tree To: hansg@kernel.org,heikki.krogerus@linux.intel.com,johannes.berg@intel.com Cc: From: Date: Sun, 21 Sep 2025 14:32:56 +0200 Message-ID: <2025092156-postal-sappiness-e1ac@gregkh> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: 8bit The patch below does not apply to the 5.10-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to . To reproduce the conflict and resubmit, you may use the following commands: git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-5.10.y git checkout FETCH_HEAD git cherry-pick -x b6f56a44e4c1014b08859dcf04ed246500e310e5 # git commit -s git send-email --to '' --in-reply-to '2025092156-postal-sappiness-e1ac@gregkh' --subject-prefix 'PATCH 5.10.y' HEAD^.. Possible dependencies: thanks, greg k-h ------------------ original commit in Linus's tree ------------------ >From b6f56a44e4c1014b08859dcf04ed246500e310e5 Mon Sep 17 00:00:00 2001 From: Hans de Goede Date: Sat, 13 Sep 2025 13:35:15 +0200 Subject: [PATCH] net: rfkill: gpio: Fix crash due to dereferencering uninitialized pointer Since commit 7d5e9737efda ("net: rfkill: gpio: get the name and type from device property") rfkill_find_type() gets called with the possibly uninitialized "const char *type_name;" local variable. On x86 systems when rfkill-gpio binds to a "BCM4752" or "LNV4752" acpi_device, the rfkill->type is set based on the ACPI acpi_device_id: rfkill->type = (unsigned)id->driver_data; and there is no "type" property so device_property_read_string() will fail and leave type_name uninitialized, leading to a potential crash. rfkill_find_type() does accept a NULL pointer, fix the potential crash by initializing type_name to NULL. Note likely sofar this has not been caught because: 1. Not many x86 machines actually have a "BCM4752"/"LNV4752" acpi_device 2. The stack happened to contain NULL where type_name is stored Fixes: 7d5e9737efda ("net: rfkill: gpio: get the name and type from device property") Cc: stable@vger.kernel.org Cc: Heikki Krogerus Signed-off-by: Hans de Goede Reviewed-by: Heikki Krogerus Link: https://patch.msgid.link/20250913113515.21698-1-hansg@kernel.org Signed-off-by: Johannes Berg diff --git a/net/rfkill/rfkill-gpio.c b/net/rfkill/rfkill-gpio.c index 41e657e97761..cf2dcec6ce5a 100644 --- a/net/rfkill/rfkill-gpio.c +++ b/net/rfkill/rfkill-gpio.c @@ -94,10 +94,10 @@ static const struct dmi_system_id rfkill_gpio_deny_table[] = { static int rfkill_gpio_probe(struct platform_device *pdev) { struct rfkill_gpio_data *rfkill; - struct gpio_desc *gpio; + const char *type_name = NULL; const char *name_property; const char *type_property; - const char *type_name; + struct gpio_desc *gpio; int ret; if (dmi_check_system(rfkill_gpio_deny_table))