Re: [PATCH 5/7 6.12.y] minmax.h: move all the clamp() definitions after the min/max() ones

[Greg KH <gregkh@linuxfoundation.org>]

On Mon, Sep 22, 2025 at 10:31:21AM +0000, Eliav Farber wrote:
> From: David Laight <David.Laight@ACULAB.COM>
> 
> [ Upstream commit c3939872ee4a6b8bdcd0e813c66823b31e6e26f7 ]
> 
> At some point the definitions for clamp() got added in the middle of the
> ones for min() and max().  Re-order the definitions so they are more
> sensibly grouped.
> 
> Link: https://lkml.kernel.org/r/8bb285818e4846469121c8abc3dfb6e2@AcuMS.aculab.com
> Signed-off-by: David Laight <david.laight@aculab.com>
> Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Cc: Arnd Bergmann <arnd@kernel.org>
> Cc: Christoph Hellwig <hch@infradead.org>
> Cc: Dan Carpenter <dan.carpenter@linaro.org>
> Cc: Jason A. Donenfeld <Jason@zx2c4.com>
> Cc: Jens Axboe <axboe@kernel.dk>
> Cc: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
> Cc: Mateusz Guzik <mjguzik@gmail.com>
> Cc: Matthew Wilcox <willy@infradead.org>
> Cc: Pedro Falcato <pedro.falcato@gmail.com>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> Signed-off-by: Eliav Farber <farbere@amazon.com>
> ---
>  include/linux/minmax.h | 109 +++++++++++++++++++----------------------
>  1 file changed, 51 insertions(+), 58 deletions(-)

This diff looks odd.  The upstream commit diffstat is:

include/linux/minmax.h |  131 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++----------------------------------------------------------------
1 file changed, 62 insertions(+), 69 deletions(-)

which does not match this diffstat, nor the diff itself.

But, if I backport the original commit myself, it matches up exactly
with what you show here, which is odd.

diff is "fun", ugh...

Anyway, not a complaint, just something that others might note if they
are comparing diffs here like I do.

thanks,

greg k-h