From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B4B6E2820D1; Mon, 22 Sep 2025 19:39:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758569995; cv=none; b=idrwykr1CfjS8JC5To7fqCmqiNK0oBFTsNXRQeTI+cIK2YKle/04Ko+8knGSQiUDydMDCm7y8bzdatRlkyDRLgXiY7tTnqae49J/Xwb3W4bNiZOsewx7KI1QbK89d48v1bfh2+w4MtNJ70zoC6sJY2qfuna1XISn5N16M6ag4sM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758569995; c=relaxed/simple; bh=sGtjosNp28G7SNw6DZIypOe/tuh07DvmbJ6ZCX2bl/s=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=KxpNvq2vemponMrAunI9D8t//BEMMjine79aAQAjATeaeiilm0YAOFZ7gIhKeGfcevTnGup4dP/KCI3aM/AiK3/FVw8AxUp6eh8yxONGHEG7rNA33Z+x5QYprUsAa9mk2Dvb25c+PfTZyVktctdUggzoa/XqGHMNJ3wS2yuI2Jo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=CWW18RXp; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="CWW18RXp" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4EAFBC4CEF0; Mon, 22 Sep 2025 19:39:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1758569995; bh=sGtjosNp28G7SNw6DZIypOe/tuh07DvmbJ6ZCX2bl/s=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=CWW18RXpMtpj7AdVZJCiU5cR3doPaESSNNvCT5e1zqJGGytvWd3eRoGyue1fwdwni 5V8z6KWtSXm5W8ghVTu2GVwPYsT1wY5CBb1WsKF2JLzeSKBuRmHUpKbThRcA7WX/Qx OqmiyveU8IO1XbDIOEGc6r888Ftnw9cHgq0tVNjk= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Heikki Krogerus , Hans de Goede , Johannes Berg Subject: [PATCH 6.12 060/105] net: rfkill: gpio: Fix crash due to dereferencering uninitialized pointer Date: Mon, 22 Sep 2025 21:29:43 +0200 Message-ID: <20250922192410.486862611@linuxfoundation.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250922192408.913556629@linuxfoundation.org> References: <20250922192408.913556629@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.12-stable review patch. If anyone has any objections, please let me know. ------------------ From: Hans de Goede commit b6f56a44e4c1014b08859dcf04ed246500e310e5 upstream. Since commit 7d5e9737efda ("net: rfkill: gpio: get the name and type from device property") rfkill_find_type() gets called with the possibly uninitialized "const char *type_name;" local variable. On x86 systems when rfkill-gpio binds to a "BCM4752" or "LNV4752" acpi_device, the rfkill->type is set based on the ACPI acpi_device_id: rfkill->type = (unsigned)id->driver_data; and there is no "type" property so device_property_read_string() will fail and leave type_name uninitialized, leading to a potential crash. rfkill_find_type() does accept a NULL pointer, fix the potential crash by initializing type_name to NULL. Note likely sofar this has not been caught because: 1. Not many x86 machines actually have a "BCM4752"/"LNV4752" acpi_device 2. The stack happened to contain NULL where type_name is stored Fixes: 7d5e9737efda ("net: rfkill: gpio: get the name and type from device property") Cc: stable@vger.kernel.org Cc: Heikki Krogerus Signed-off-by: Hans de Goede Reviewed-by: Heikki Krogerus Link: https://patch.msgid.link/20250913113515.21698-1-hansg@kernel.org Signed-off-by: Johannes Berg Signed-off-by: Greg Kroah-Hartman --- net/rfkill/rfkill-gpio.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/net/rfkill/rfkill-gpio.c +++ b/net/rfkill/rfkill-gpio.c @@ -94,10 +94,10 @@ static const struct dmi_system_id rfkill static int rfkill_gpio_probe(struct platform_device *pdev) { struct rfkill_gpio_data *rfkill; - struct gpio_desc *gpio; + const char *type_name = NULL; const char *name_property; const char *type_property; - const char *type_name; + struct gpio_desc *gpio; int ret; if (dmi_check_system(rfkill_gpio_deny_table))