From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 169D531C57B; Mon, 22 Sep 2025 19:40:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758570014; cv=none; b=pYiehfZZJOyDi2xQmXsmQjTytKaQ2GFqnrmwwHxjvlvYF6G3tAHAzd9+9NuoBTTYCEVX0yIjlT6lf1cTGFENR7w0DxNTg6kQETMpsziNC7FhcnzYHMFpkT075yvqgnWFdgC24IJB7fN9llpNUwN9oth8DwpWLtQwwRUElfEud0Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758570014; c=relaxed/simple; bh=QP2hKpTZRQ3zxndFKZXgtWtgw5k12ckoClCPf71XHWU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=UU55BM5O544q/4QOhfWdeKJNxXz2t1d0bKy6A0K2c7c5EYst7CJt1lvhTtm+BG2y4En2XgMF3uKVaxJx2rcCQUEKl+uysWLycTfXtl9b3qN4VPlMOMFMx2PxHuBNgekgloT8Gq87JPJ5+owrdohEhMWmhS0Qr0AQmp4D1ttbchs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=MnvO2nXl; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="MnvO2nXl" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1929BC116C6; Mon, 22 Sep 2025 19:40:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1758570013; bh=QP2hKpTZRQ3zxndFKZXgtWtgw5k12ckoClCPf71XHWU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=MnvO2nXlje37o5Pl7g3s3Fg69HYwouxjbQccBd5GeGfw/mlQ3Fpy/BT+UGXoenlhE 1+VQt8YB8yCZKq77f2Di5+8r5WiFcpLMSG7XB0UbEfChctOkM6vECee6T7hSHqbO+j aWMDm3VzedXQNMiTlBVVU3FVPy1cdvdLT/i9/VeU= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Himal Prasad Ghimiray , Matthew Brost , Shuicheng Lin , Lucas De Marchi , Rodrigo Vivi , Sasha Levin Subject: [PATCH 6.12 076/105] drm/xe/tile: Release kobject for the failure path Date: Mon, 22 Sep 2025 21:29:59 +0200 Message-ID: <20250922192410.887466867@linuxfoundation.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250922192408.913556629@linuxfoundation.org> References: <20250922192408.913556629@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.12-stable review patch. If anyone has any objections, please let me know. ------------------ From: Shuicheng Lin [ Upstream commit 013e484dbd687a9174acf8f4450217bdb86ad788 ] Call kobject_put() for the failure path to release the kobject v2: remove extra newline. (Matt) Fixes: e3d0839aa501 ("drm/xe/tile: Abort driver load for sysfs creation failure") Cc: Himal Prasad Ghimiray Reviewed-by: Matthew Brost Signed-off-by: Shuicheng Lin Link: https://lore.kernel.org/r/20250819153950.2973344-2-shuicheng.lin@intel.com Signed-off-by: Lucas De Marchi (cherry picked from commit b98775bca99511cc22ab459a2de646cd2fa7241f) Signed-off-by: Rodrigo Vivi Signed-off-by: Sasha Levin --- drivers/gpu/drm/xe/xe_tile_sysfs.c | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/xe/xe_tile_sysfs.c b/drivers/gpu/drm/xe/xe_tile_sysfs.c index b804234a65516..9e1236a9ec673 100644 --- a/drivers/gpu/drm/xe/xe_tile_sysfs.c +++ b/drivers/gpu/drm/xe/xe_tile_sysfs.c @@ -44,16 +44,18 @@ int xe_tile_sysfs_init(struct xe_tile *tile) kt->tile = tile; err = kobject_add(&kt->base, &dev->kobj, "tile%d", tile->id); - if (err) { - kobject_put(&kt->base); - return err; - } + if (err) + goto err_object; tile->sysfs = &kt->base; err = xe_vram_freq_sysfs_init(tile); if (err) - return err; + goto err_object; return devm_add_action_or_reset(xe->drm.dev, tile_sysfs_fini, tile); + +err_object: + kobject_put(&kt->base); + return err; } -- 2.51.0