From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 177DE304989; Tue, 30 Sep 2025 14:59:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759244369; cv=none; b=aeMBu95yJ/303X7QeVoj7TLehNWd+XQjKwRRah8wpg9PdD3E0AXue+EOcvbfjkW2Qurq/38LShu0X4gZt+z5oiEz8hzZzIru+imD50y+pe0N62oVQd9WlGhC6G0VWdkm0kW2B3X1ZVC0iT8Wg3Fw/mUb8f3QCeHNaZpbK3tV7/E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759244369; c=relaxed/simple; bh=iJ+2U24oi9zLDLKVvEEOfOyEoEkWeSzynjXqh4UoNxY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=BhvbOTOXS9l7AohZIWBYV85tExIDy8LRGJP0kLloo/lVzstlO5PJONZrY3I0C29l0DajH1kaQ2U7VJisF5pZ6DXR2W3Y95bo58wzGf+nPVj/RTq5ghLp39zAA2AyzLb+h00CUg9AAah1eLHZ4RQ08ek2HlVtBRRI2m/2UQrxby8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=XWGJUstn; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="XWGJUstn" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 77A71C4CEF0; Tue, 30 Sep 2025 14:59:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1759244369; bh=iJ+2U24oi9zLDLKVvEEOfOyEoEkWeSzynjXqh4UoNxY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=XWGJUstnle7g03nyAhnfKKeaM92zYuFXGkcLR8VLKdZRsQkIiEsIj35//mgg4wO6H SHjFB9Yndyi+NmaNPKM7HPSQHWrXuMAKG7KnAbjcgGroywlnQoUe2qYov1mwiPdizC lz5/CBIpTol5eu0qoOz/6cundRyA+a1XeNIQGFDY= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Zabelin Nikita , Patrik Jakobsson , Sasha Levin Subject: [PATCH 5.10 108/122] drm/gma500: Fix null dereference in hdmi teardown Date: Tue, 30 Sep 2025 16:47:19 +0200 Message-ID: <20250930143827.394105743@linuxfoundation.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250930143822.939301999@linuxfoundation.org> References: <20250930143822.939301999@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Zabelin Nikita [ Upstream commit 352e66900cde63f3dadb142364d3c35170bbaaff ] pci_set_drvdata sets the value of pdev->driver_data to NULL, after which the driver_data obtained from the same dev is dereferenced in oaktrail_hdmi_i2c_exit, and the i2c_dev is extracted from it. To prevent this, swap these calls. Found by Linux Verification Center (linuxtesting.org) with Svacer. Fixes: 1b082ccf5901 ("gma500: Add Oaktrail support") Signed-off-by: Zabelin Nikita Signed-off-by: Patrik Jakobsson Link: https://lore.kernel.org/r/20250918150703.2562604-1-n.zabelin@mt-integration.ru Signed-off-by: Sasha Levin --- drivers/gpu/drm/gma500/oaktrail_hdmi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/gma500/oaktrail_hdmi.c b/drivers/gpu/drm/gma500/oaktrail_hdmi.c index a097a59a9eaec..08e83b7513197 100644 --- a/drivers/gpu/drm/gma500/oaktrail_hdmi.c +++ b/drivers/gpu/drm/gma500/oaktrail_hdmi.c @@ -724,8 +724,8 @@ void oaktrail_hdmi_teardown(struct drm_device *dev) if (hdmi_dev) { pdev = hdmi_dev->dev; - pci_set_drvdata(pdev, NULL); oaktrail_hdmi_i2c_exit(pdev); + pci_set_drvdata(pdev, NULL); iounmap(hdmi_dev->regs); kfree(hdmi_dev); pci_dev_put(pdev); -- 2.51.0