From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 24B022FFDE6; Tue, 30 Sep 2025 14:59:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759244389; cv=none; b=jgI9CXDlH/rhkjDLFa5d2pAnli1mYS5uXYN9aBqG9MWZa3qZB4B+jt/c1TyT4+bNwY3CA3KbODADLyyVvsOi6V1rO6/3W3RFDT6BdQHakRBF2RgeIOqjBtZuCZlRsMxmZN4u/SqGPgqyXLlzOP9YWBKPS737xmZcmpJdBYdh4Ic= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759244389; c=relaxed/simple; bh=b4p6GwJfVm98Xm6vRBzZZFsRv1EVMbqf9wDj5sG/5lw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=FXvBxDX2W7QFQlpeJWYaWdsxRhMPDDUTNiT2tv43vRMPuSg+hu97TAUVtuHziBAowxVWaC/X4ER4qVRoWuEzDUJt0ql5GyUB6kSpBKzfN6h3XCOaWJQ5+y3FCZvMy5ULdQBbUp+HdrcRXw8ZoqknB+m3uKXyIhnCQj/uDr7Xo3k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=wwCHUj65; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="wwCHUj65" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9FC5BC4CEF0; Tue, 30 Sep 2025 14:59:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1759244389; bh=b4p6GwJfVm98Xm6vRBzZZFsRv1EVMbqf9wDj5sG/5lw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=wwCHUj65cwFuVFIiBe6u7nmNn0S/N1FB3xJ3KNB4CGZS7wortOMmQtD1zWvL9LwUU lg85bWos9CW2fjox2JYMYNDZHIn4IZ8nDlSGl3eJRevvXq/8OtIJmSgXxHwIQ7NmKo yYCkoUCy/yTou1jcuYvZNX4XiqQeYA5DpUyiM5WQ= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Lukasz Czapnik , Aleksandr Loktionov , Przemek Kitszel , Simon Horman , Rafal Romanowski , Tony Nguyen Subject: [PATCH 5.10 113/122] i40e: add mask to apply valid bits for itr_idx Date: Tue, 30 Sep 2025 16:47:24 +0200 Message-ID: <20250930143827.592466052@linuxfoundation.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20250930143822.939301999@linuxfoundation.org> References: <20250930143822.939301999@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Lukasz Czapnik commit eac04428abe9f9cb203ffae4600791ea1d24eb18 upstream. The ITR index (itr_idx) is only 2 bits wide. When constructing the register value for QINT_RQCTL, all fields are ORed together. Without masking, higher bits from itr_idx may overwrite adjacent fields in the register. Apply I40E_QINT_RQCTL_ITR_INDX_MASK to ensure only the intended bits are set. Fixes: 5c3c48ac6bf5 ("i40e: implement virtual device interface") Cc: stable@vger.kernel.org Signed-off-by: Lukasz Czapnik Reviewed-by: Aleksandr Loktionov Signed-off-by: Przemek Kitszel Reviewed-by: Simon Horman Tested-by: Rafal Romanowski Signed-off-by: Tony Nguyen Signed-off-by: Greg Kroah-Hartman --- drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c +++ b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c @@ -393,7 +393,7 @@ static void i40e_config_irq_link_list(st (qtype << I40E_QINT_RQCTL_NEXTQ_TYPE_SHIFT) | (pf_queue_id << I40E_QINT_RQCTL_NEXTQ_INDX_SHIFT) | BIT(I40E_QINT_RQCTL_CAUSE_ENA_SHIFT) | - (itr_idx << I40E_QINT_RQCTL_ITR_INDX_SHIFT); + FIELD_PREP(I40E_QINT_RQCTL_ITR_INDX_MASK, itr_idx); wr32(hw, reg_idx, reg); }