From: Greg KH <gregkh@linuxfoundation.org>
To: Mathias Nyman <mathias.nyman@linux.intel.com>
Cc: Niklas Neronin <niklas.neronin@linux.intel.com>,
stable@vger.kernel.org, Wolfgang Walter <linux@stwm.de>
Subject: Re: [PATCH] Revert "usb: xhci: remove option to change a default ring's TRB cycle bit"
Date: Tue, 30 Sep 2025 16:04:07 +0200 [thread overview]
Message-ID: <2025093059-unrobed-eligible-ae6c@gregkh> (raw)
In-Reply-To: <902780b3-7bc0-431d-bbb7-fe7b7b7fabd7@linux.intel.com>
On Tue, Sep 30, 2025 at 04:51:35PM +0300, Mathias Nyman wrote:
> On 9/30/25 16:22, Niklas Neronin wrote:
> > Revert 9b28ef1e4cc0 [ Upstream commit e1b0fa863907 ], it causes regression
> > in 6.12.49 stable, no issues in upstream.
> >
> > Commit 9b28ef1e4cc0 ("usb: xhci: remove option to change a default ring's
> > TRB cycle bit") introduced a regression in 6.12.49 stable kernel.
> > The original commit was never intended for stable kernels, but was added
> > as a dependency for commit a5c98e8b1398 ("xhci: dbc: Fix full DbC transfer
> > ring after several reconnects").
> >
> > Since this commit is more of an optimization, revert it and solve the
> > dependecy by modifying one line in xhci_dbc_ring_init(). Specifically,
> > commit a5c98e8b1398 ("xhci: dbc: Fix full DbC transfer ring after several
> > reconnects") moved function call xhci_initialize_ring_info() into a
> > separate function. To resolve the dependency, the arguments for this
> > function call are also reverted.
> >
> > Closes: https://lore.kernel.org/stable/01b8c8de46251cfaad1329a46b7e3738@stwm.de/
> > Tested-by: Wolfgang Walter <linux@stwm.de>
> > Cc: stable@vger.kernel.org # v6.12.49
> > Signed-off-by: Niklas Neronin <niklas.neronin@linux.intel.com>
>
> Acked-by: Mathias Nyman <mathias.nyman@linux.intel.com>
Thanks, now queued up.
greg k-h
prev parent reply other threads:[~2025-09-30 14:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-30 13:22 [PATCH] Revert "usb: xhci: remove option to change a default ring's TRB cycle bit" Niklas Neronin
2025-09-30 13:51 ` Mathias Nyman
2025-09-30 14:04 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025093059-unrobed-eligible-ae6c@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=linux@stwm.de \
--cc=mathias.nyman@linux.intel.com \
--cc=niklas.neronin@linux.intel.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox