From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5640C189F5C; Mon, 6 Oct 2025 09:24:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759742659; cv=none; b=CeK1Mq38rusfXazb/hRW3FirH9zQK2Bb1ZIWVP3eyTyaumt3v3hv6vC6ooKwV8XI/Hg+YEq+y+ielbrKkT2lT1xFY5Lc5B/nHoKTkwR3+GD7/+5KppK2I2t8VXnOkqvkioX1Ohvb5i9K30XKRrm8i5vp3QZeZq1IntG5SajsvjQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759742659; c=relaxed/simple; bh=HQO3BghtODWv879KhWCgZnbHiA4tn37XW6G/0phmyiM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ut5BfhlVpUatK/ZR8WiVsBeQZePq2DH7ut/kdsoiNDQkjFbVIDFsBpouKls+r6ircMwiddauLJzXdxEi5gKl6fAVXBpDV7ZDUwTinTJjigL+NAPrgHUaoygPwwqBPl0XNOPhpdqeze8ZnTlqoauvTwrE5aabH0wEzZS7TspREWg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=VA3uEPwF; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="VA3uEPwF" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 654C2C4CEF5; Mon, 6 Oct 2025 09:24:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1759742658; bh=HQO3BghtODWv879KhWCgZnbHiA4tn37XW6G/0phmyiM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=VA3uEPwFkNliMXoB/m6c7pfq6D1t9SI6qJhehWlhberWyJMjEggmJ5zXNZ8KXSgxp OsmmLouSqojpfzzBZ67hp+0ZHnJc1wviJnsS0DnFFGXYn+y6jJQLkT/O3cjjyST6Id UqH+b7kXINz76cn9gUtVG5MlwzCfNbegJGQX3fdQ= Date: Mon, 6 Oct 2025 11:24:16 +0200 From: Greg Kroah-Hartman To: Maarten Lankhorst Cc: Mukesh Ojha , linux-kernel@vger.kernel.org, intel-xe@lists.freedesktop.org, Mukesh Ojha , Johannes Berg , "Rafael J. Wysocki" , Danilo Krummrich , stable@vger.kernel.org, Matthew Brost Subject: Re: [PATCH] devcoredump: Fix circular locking dependency with devcd->mutex. Message-ID: <2025100655-prankish-parking-9059@gregkh> References: <20250723142416.1020423-1-dev@lankhorst.se> <20251003180052.wpx4d5mqs6tmmber@hu-mojha-hyd.qualcomm.com> <977e15c2-ad91-45c4-be99-0390ae7f8315@lankhorst.se> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <977e15c2-ad91-45c4-be99-0390ae7f8315@lankhorst.se> On Mon, Oct 06, 2025 at 11:11:01AM +0200, Maarten Lankhorst wrote: > >> @@ -401,13 +424,20 @@ void dev_coredumpm_timeout(struct device *dev, struct module *owner, > >> > >> dev_set_uevent_suppress(&devcd->devcd_dev, false); > >> kobject_uevent(&devcd->devcd_dev.kobj, KOBJ_ADD); > >> - INIT_DELAYED_WORK(&devcd->del_wk, devcd_del); > >> - schedule_delayed_work(&devcd->del_wk, timeout); > >> + > >> + /* > >> + * Safe to run devcd_del() now that we are done with devcd_dev. > >> + * Alternatively we could have taken a ref on devcd_dev before > >> + * dropping the lock. > >> + */ > >> + devcd->init_completed = true; > >> mutex_unlock(&devcd->mutex); > >> return; > >> put_device: > >> - put_device(&devcd->devcd_dev); > >> mutex_unlock(&devcd->mutex); > >> + cancel_delayed_work_sync(&devcd->del_wk); > >> + put_device(&devcd->devcd_dev); > >> + > > > > Acked-by: Mukesh Ojha > > Thanks, through what tree can this be merged? I can look into doing that after -rc1 is out. thanks, greg k-h