From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C18B53126B8 for ; Mon, 13 Oct 2025 21:57:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760392625; cv=none; b=pwPaDz4kxjXGwK7fG42lw35jysr8beA+CFs7OCOrDrs7m8kO8OTcblkHDJHwSvRC+4ARNOTDycbsNMaGm+mrYXyKPd+H8O4jr9VuMQWjPHr79nfvwmQBDIzySBFq8r1KnY4A+RnPRWRR+Cnbsp0ei5XYd/SdwVL2wYAVpQXi+R8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760392625; c=relaxed/simple; bh=dZZVjMZlX27ZuQusbI2TT5vrXyNcbiQ1O8qfhefjGXs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=CszkNsUIjp54XrehtlXmXWv3rDck5DKx1vF5ICZF3eRA4yk3aBmexbK7984tf8+79JgKAaAWyzD/3VwanQOpBMdV7YN2pu6xeZDms9HYfVmElzo0WasE2INVrJKYtapAyNHcTfhiu5u2jJ4HjmExn9EiRg3QyMmnyVDSPowF99U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=nzqc9kxK; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="nzqc9kxK" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8B626C2BD01; Mon, 13 Oct 2025 21:57:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1760392624; bh=dZZVjMZlX27ZuQusbI2TT5vrXyNcbiQ1O8qfhefjGXs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=nzqc9kxK2oz9gR/H/huT6ZOy0SNs/vTjTj5tz58tJRqxKNk7xM9UXAvO2T59yluBK 0T3AyN+t1G1ckMHrCKv8+FzElOmzHm9DDkyWYgrmEiNwVrcnbANk8ZwZ9xD687mFIL 9PuaftXLJdmPOnD+DlOSAlDFmiWauUAqh+JLZ1xUDO+3pNrA129pcwYTihqFwXrRin k4C++JQMhTWBSByD90q4AVXZytS0O0Cwezz4cbsc9JgGFsUxuCfOY42dfdSM9PIemE mxDNlTvkFUhqNZU5Dluej9O7HSWN5S4V6O5qk59pkZQ/mDiTwPN0j9T/N6HWppkdPR hYYj8z+rGu7Xw== From: Sasha Levin To: stable@vger.kernel.org Cc: Phillip Lougher , Andrew Morton , Sasha Levin Subject: [PATCH 5.10.y 1/2] Squashfs: add additional inode sanity checking Date: Mon, 13 Oct 2025 17:57:00 -0400 Message-ID: <20251013215701.3645486-1-sashal@kernel.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <2025101321-ripening-subscript-11b6@gregkh> References: <2025101321-ripening-subscript-11b6@gregkh> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Phillip Lougher [ Upstream commit 9ee94bfbe930a1b39df53fa2d7b31141b780eb5a ] Patch series "Squashfs: performance improvement and a sanity check". This patchset adds an additional sanity check when reading regular file inodes, and adds support for SEEK_DATA/SEEK_HOLE lseek() whence values. This patch (of 2): Add an additional sanity check when reading regular file inodes. A regular file if the file size is an exact multiple of the filesystem block size cannot have a fragment. This is because by definition a fragment block stores tailends which are not a whole block in size. Link: https://lkml.kernel.org/r/20250923220652.568416-1-phillip@squashfs.org.uk Link: https://lkml.kernel.org/r/20250923220652.568416-2-phillip@squashfs.org.uk Signed-off-by: Phillip Lougher Signed-off-by: Andrew Morton Stable-dep-of: 9f1c14c1de1b ("Squashfs: reject negative file sizes in squashfs_read_inode()") Signed-off-by: Sasha Levin --- fs/squashfs/inode.c | 20 ++++++++++++++++++-- 1 file changed, 18 insertions(+), 2 deletions(-) diff --git a/fs/squashfs/inode.c b/fs/squashfs/inode.c index 95a9ff9e23997..eb6f577154d59 100644 --- a/fs/squashfs/inode.c +++ b/fs/squashfs/inode.c @@ -140,8 +140,17 @@ int squashfs_read_inode(struct inode *inode, long long ino) if (err < 0) goto failed_read; + inode->i_size = le32_to_cpu(sqsh_ino->file_size); frag = le32_to_cpu(sqsh_ino->fragment); if (frag != SQUASHFS_INVALID_FRAG) { + /* + * the file cannot have a fragment (tailend) and have a + * file size a multiple of the block size + */ + if ((inode->i_size & (msblk->block_size - 1)) == 0) { + err = -EINVAL; + goto failed_read; + } frag_offset = le32_to_cpu(sqsh_ino->offset); frag_size = squashfs_frag_lookup(sb, frag, &frag_blk); if (frag_size < 0) { @@ -155,7 +164,6 @@ int squashfs_read_inode(struct inode *inode, long long ino) } set_nlink(inode, 1); - inode->i_size = le32_to_cpu(sqsh_ino->file_size); inode->i_fop = &generic_ro_fops; inode->i_mode |= S_IFREG; inode->i_blocks = ((inode->i_size - 1) >> 9) + 1; @@ -183,8 +191,17 @@ int squashfs_read_inode(struct inode *inode, long long ino) if (err < 0) goto failed_read; + inode->i_size = le64_to_cpu(sqsh_ino->file_size); frag = le32_to_cpu(sqsh_ino->fragment); if (frag != SQUASHFS_INVALID_FRAG) { + /* + * the file cannot have a fragment (tailend) and have a + * file size a multiple of the block size + */ + if ((inode->i_size & (msblk->block_size - 1)) == 0) { + err = -EINVAL; + goto failed_read; + } frag_offset = le32_to_cpu(sqsh_ino->offset); frag_size = squashfs_frag_lookup(sb, frag, &frag_blk); if (frag_size < 0) { @@ -199,7 +216,6 @@ int squashfs_read_inode(struct inode *inode, long long ino) xattr_id = le32_to_cpu(sqsh_ino->xattr); set_nlink(inode, le32_to_cpu(sqsh_ino->nlink)); - inode->i_size = le64_to_cpu(sqsh_ino->file_size); inode->i_op = &squashfs_inode_ops; inode->i_fop = &generic_ro_fops; inode->i_mode |= S_IFREG; -- 2.51.0