From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C18383126AF for ; Mon, 13 Oct 2025 21:57:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760392625; cv=none; b=qyIs++yYoR2Hr4jyJaEntPbbni1QC2hA9G42ga+ptwdQroLbyDUPqUuRVUyNtnXyCmJvzDdQFZV8RplXPQHhDXEMobaemOmGSv1628MJ1orEVUuvyHrGgz7j9YHQLs4IdR5mbZS2tkC+e0q7ChUwFyvrSRoJ6ZwN8tKT/Vm59sY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760392625; c=relaxed/simple; bh=auI4kF96Ov5mjIOIHXwuNHhvI0RkFNraAXup3IXlDZI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=C3GdEuVpUzpE4Itnv0qEdPw+f+ezpd4bhYWFIq1XPQR1eM0msvKgA3B+O1YswKIB/6InPkMGXRGtmtur9yrKbW4WhtJKOGIaijdyPupq0uw9uPtyHTO/WMmHpKuypfQJdc7KAfni1O2hnzCLX73ZBRwr+XmCBG47L43B4Q5lYaU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=btCgCWYZ; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="btCgCWYZ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 765FEC2BCB0; Mon, 13 Oct 2025 21:57:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1760392625; bh=auI4kF96Ov5mjIOIHXwuNHhvI0RkFNraAXup3IXlDZI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=btCgCWYZGN39S8Fqnv4PJrbYK4yBxrERHyZcjEfjZQps9TuOj0cjC7hEUpn7vtOmm WvGzUs+KD3bmrjHlL8b1U2KvfYPHyGcSROWWGITKC0d4lBC5ypSa5rUBaj6Dm3phXC 1+EVIwbQQ0TFCung471DUaJyh3tPhGLX5M5nmTyUn5en0xB3uMXtTfa90TDr6uYMA/ b/Pp+842/7bZ1KUfKXRdrZ3Z6ydLeRg7yo6bXUSkImz+iqQBJcAOo/VmW2JxWH4B5C FsUJDtY6qKJbwA5egI8tbqiqcCRMSzNdE1DXNjFvcDpdcqvgkrPlc8zQieAEuPrXXx XXAbi7jNU0L0A== From: Sasha Levin To: stable@vger.kernel.org Cc: Phillip Lougher , syzbot+f754e01116421e9754b9@syzkaller.appspotmail.com, Amir Goldstein , Andrew Morton , Sasha Levin Subject: [PATCH 5.10.y 2/2] Squashfs: reject negative file sizes in squashfs_read_inode() Date: Mon, 13 Oct 2025 17:57:01 -0400 Message-ID: <20251013215701.3645486-2-sashal@kernel.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251013215701.3645486-1-sashal@kernel.org> References: <2025101321-ripening-subscript-11b6@gregkh> <20251013215701.3645486-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Phillip Lougher [ Upstream commit 9f1c14c1de1bdde395f6cc893efa4f80a2ae3b2b ] Syskaller reports a "WARNING in ovl_copy_up_file" in overlayfs. This warning is ultimately caused because the underlying Squashfs file system returns a file with a negative file size. This commit checks for a negative file size and returns EINVAL. [phillip@squashfs.org.uk: only need to check 64 bit quantity] Link: https://lkml.kernel.org/r/20250926222305.110103-1-phillip@squashfs.org.uk Link: https://lkml.kernel.org/r/20250926215935.107233-1-phillip@squashfs.org.uk Fixes: 6545b246a2c8 ("Squashfs: inode operations") Signed-off-by: Phillip Lougher Reported-by: syzbot+f754e01116421e9754b9@syzkaller.appspotmail.com Closes: https://lore.kernel.org/all/68d580e5.a00a0220.303701.0019.GAE@google.com/ Cc: Amir Goldstein Cc: Signed-off-by: Andrew Morton Signed-off-by: Sasha Levin --- fs/squashfs/inode.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/fs/squashfs/inode.c b/fs/squashfs/inode.c index eb6f577154d59..f32db16dc18ba 100644 --- a/fs/squashfs/inode.c +++ b/fs/squashfs/inode.c @@ -192,6 +192,10 @@ int squashfs_read_inode(struct inode *inode, long long ino) goto failed_read; inode->i_size = le64_to_cpu(sqsh_ino->file_size); + if (inode->i_size < 0) { + err = -EINVAL; + goto failed_read; + } frag = le32_to_cpu(sqsh_ino->fragment); if (frag != SQUASHFS_INVALID_FRAG) { /* -- 2.51.0