From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 777AD2E92B7 for ; Mon, 13 Oct 2025 07:49:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760341779; cv=none; b=J7En1C6Vjnu9l5Rq38OT+P9hlHUBXDtZnaEKTP3nudYIfNWi/+Peu39tNuZeZoKh83jx+h1UXFtLJuf3PF4NwQHqHdmZpww2ayddFyFwN0EhGK/RlWxfi4Gnr8tJlDO2H/T9P852gu7KYS426iS4r4RMCVLP9kxrsJdqG3rPVko= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760341779; c=relaxed/simple; bh=PjWmLoYiZfKYz1j2wJSfzC1YqBUt2uztQeID3dy0uNg=; h=Subject:To:Cc:From:Date:Message-ID:MIME-Version:Content-Type; b=RuYS50KSBSq4SnGiqBP3LyAT7bsKYWav2XLZsT9vSUR1p4D48FWUIstDC2tBy+w6o9LhRfERJ8DKz5bejKgenSwpUG3V2tgYdf2ripNO6rYExxgercK50wIBognCd6yK6loaPkNC19sXu0Ii4UQi1ekjcbmktaDNkgTSx8kB8XU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=iSBZx3p/; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="iSBZx3p/" Received: by smtp.kernel.org (Postfix) with ESMTPSA id ECD62C4CEE7; Mon, 13 Oct 2025 07:49:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1760341779; bh=PjWmLoYiZfKYz1j2wJSfzC1YqBUt2uztQeID3dy0uNg=; h=Subject:To:Cc:From:Date:From; b=iSBZx3p/wBGtUTwSBObSAFeup5y0F5Ylwm0R6ersy5r3lqLayJK+5flKGOBS7D6m0 +ULyOI5/xOgUkIFKZ0IdZoLXnku0mO07ZxkKHGSAt27o2LJOtY1u3F/+m6YQHn+CFc pXXRT/iBP57UUDutLS2vWoGlprrgzQc1nrcZ7ZD0= Subject: FAILED: patch "[PATCH] Squashfs: reject negative file sizes in squashfs_read_inode()" failed to apply to 5.4-stable tree To: phillip@squashfs.org.uk,akpm@linux-foundation.org,amir73il@gmail.com,stable@vger.kernel.org Cc: From: Date: Mon, 13 Oct 2025 09:49:22 +0200 Message-ID: <2025101322-kept-undone-f6f6@gregkh> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: 8bit The patch below does not apply to the 5.4-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to . To reproduce the conflict and resubmit, you may use the following commands: git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-5.4.y git checkout FETCH_HEAD git cherry-pick -x 9f1c14c1de1bdde395f6cc893efa4f80a2ae3b2b # git commit -s git send-email --to '' --in-reply-to '2025101322-kept-undone-f6f6@gregkh' --subject-prefix 'PATCH 5.4.y' HEAD^.. Possible dependencies: thanks, greg k-h ------------------ original commit in Linus's tree ------------------ >From 9f1c14c1de1bdde395f6cc893efa4f80a2ae3b2b Mon Sep 17 00:00:00 2001 From: Phillip Lougher Date: Fri, 26 Sep 2025 22:59:35 +0100 Subject: [PATCH] Squashfs: reject negative file sizes in squashfs_read_inode() Syskaller reports a "WARNING in ovl_copy_up_file" in overlayfs. This warning is ultimately caused because the underlying Squashfs file system returns a file with a negative file size. This commit checks for a negative file size and returns EINVAL. [phillip@squashfs.org.uk: only need to check 64 bit quantity] Link: https://lkml.kernel.org/r/20250926222305.110103-1-phillip@squashfs.org.uk Link: https://lkml.kernel.org/r/20250926215935.107233-1-phillip@squashfs.org.uk Fixes: 6545b246a2c8 ("Squashfs: inode operations") Signed-off-by: Phillip Lougher Reported-by: syzbot+f754e01116421e9754b9@syzkaller.appspotmail.com Closes: https://lore.kernel.org/all/68d580e5.a00a0220.303701.0019.GAE@google.com/ Cc: Amir Goldstein Cc: Signed-off-by: Andrew Morton diff --git a/fs/squashfs/inode.c b/fs/squashfs/inode.c index ddc65d006063..cceae3b78698 100644 --- a/fs/squashfs/inode.c +++ b/fs/squashfs/inode.c @@ -197,6 +197,10 @@ int squashfs_read_inode(struct inode *inode, long long ino) goto failed_read; inode->i_size = le64_to_cpu(sqsh_ino->file_size); + if (inode->i_size < 0) { + err = -EINVAL; + goto failed_read; + } frag = le32_to_cpu(sqsh_ino->fragment); if (frag != SQUASHFS_INVALID_FRAG) { /*