From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 994C61EBA19 for ; Mon, 13 Oct 2025 22:11:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760393514; cv=none; b=V9J+u79k3Tgkr2qCMQPUuKSn8HQjNh7Yg7qxr+FKloS9UYWF/4/ugPUEETkq9oJgBM1xCilLJqHENkQ0IlR2Gl5WmlvPu+A+BdXPwus659LH3ENeFEvFoXKpJ3DSJTpMpGc0zaayUZkgbJIZwrFQ81x1sMpxyJ0yBLmjWv4qYWc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760393514; c=relaxed/simple; bh=auI4kF96Ov5mjIOIHXwuNHhvI0RkFNraAXup3IXlDZI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=kII2UoyWlNVr5nncBycg09Ve0iN1yQ2IAQz9ccZw8W04YLZuTS1HXkE3cD1w1t24amkxvqo7xSQ8/fVZuqUypR5NuV8pON8S0CTaKhO9qmoq229UyllGr11cLcCUeKqSAlC07DzxeMoRcYvjWSY0dxzhFp1fmgszQBKTrJIq1bA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=C2fY62vb; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="C2fY62vb" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 70566C4CEFE; Mon, 13 Oct 2025 22:11:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1760393514; bh=auI4kF96Ov5mjIOIHXwuNHhvI0RkFNraAXup3IXlDZI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=C2fY62vbfY/9qmSlwLP0IMRkSt7Q2u89MwlP/pav2B4BJgwer8zSvgRq3J7WYSBJP 8NtEFLI9OYlC/pItqR9w8BGaFf5LLyuFNr3ZmH5yjvQoqEFaLMJgiaoNZ2wUVCNtV9 GMgtkwmedn/p4e7ZiWcBEha8GgYboraoREL2699hrpk7iHRQJSp2Ycm1X558uERiar Rqz4iap7au8Z3kwZdtTzDV2uFFsA9n7pnD0s7SuLHbvJjx7NnWL98xovRWPMICijQX lV+ZGK/2MyeOr4XCq9EUbNOuwsCSCIkrT1W7dP9YTY6aUHdQwLrif4QkzrBKr/diAF Op9T00W60uK9A== From: Sasha Levin To: stable@vger.kernel.org Cc: Phillip Lougher , syzbot+f754e01116421e9754b9@syzkaller.appspotmail.com, Amir Goldstein , Andrew Morton , Sasha Levin Subject: [PATCH 5.4.y 2/2] Squashfs: reject negative file sizes in squashfs_read_inode() Date: Mon, 13 Oct 2025 18:11:50 -0400 Message-ID: <20251013221150.3655714-2-sashal@kernel.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251013221150.3655714-1-sashal@kernel.org> References: <2025101322-kept-undone-f6f6@gregkh> <20251013221150.3655714-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Phillip Lougher [ Upstream commit 9f1c14c1de1bdde395f6cc893efa4f80a2ae3b2b ] Syskaller reports a "WARNING in ovl_copy_up_file" in overlayfs. This warning is ultimately caused because the underlying Squashfs file system returns a file with a negative file size. This commit checks for a negative file size and returns EINVAL. [phillip@squashfs.org.uk: only need to check 64 bit quantity] Link: https://lkml.kernel.org/r/20250926222305.110103-1-phillip@squashfs.org.uk Link: https://lkml.kernel.org/r/20250926215935.107233-1-phillip@squashfs.org.uk Fixes: 6545b246a2c8 ("Squashfs: inode operations") Signed-off-by: Phillip Lougher Reported-by: syzbot+f754e01116421e9754b9@syzkaller.appspotmail.com Closes: https://lore.kernel.org/all/68d580e5.a00a0220.303701.0019.GAE@google.com/ Cc: Amir Goldstein Cc: Signed-off-by: Andrew Morton Signed-off-by: Sasha Levin --- fs/squashfs/inode.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/fs/squashfs/inode.c b/fs/squashfs/inode.c index eb6f577154d59..f32db16dc18ba 100644 --- a/fs/squashfs/inode.c +++ b/fs/squashfs/inode.c @@ -192,6 +192,10 @@ int squashfs_read_inode(struct inode *inode, long long ino) goto failed_read; inode->i_size = le64_to_cpu(sqsh_ino->file_size); + if (inode->i_size < 0) { + err = -EINVAL; + goto failed_read; + } frag = le32_to_cpu(sqsh_ino->fragment); if (frag != SQUASHFS_INVALID_FRAG) { /* -- 2.51.0