From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3CC90334381 for ; Thu, 16 Oct 2025 12:54:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760619258; cv=none; b=iDfyOxnKeYYF1hqwiZinBHinsach64OWMFzdsjm5aUk82z+cicFFBNCqVTr6KsvE4quA16Twu4bI9wau0dSWmmF3PtDRyWNH9bXKXJvS+viMJGh4o4Gz5vp74zub7Bd3krGdHTzLCpjEg3ZOzXGIGk9hy0bMnrQDUUkYpVG3T8k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760619258; c=relaxed/simple; bh=QuI4YncnuFuYrrtyHDeeOLx3wtnlN032Jpqp7An4ZK0=; h=Subject:To:Cc:From:Date:Message-ID:MIME-Version:Content-Type; b=sHyvSDuMvu0OWv0es/WW7ECJacgUmwdNQfN/a/rjYDFVMVitgSf8Qh9HZsqWssAzOlA3o/5s0BZgLGdo1+bOKiaPi6M9FbMv6MbMu7Bo39u6uD6r71hEGD/EW+yGwCaA5YhIMhmqWZKwuyfiHoHG66dkVKqn3ISk1vUB3vpiJ4o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=vAVlsD8K; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="vAVlsD8K" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B2946C4CEF1; Thu, 16 Oct 2025 12:54:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1760619258; bh=QuI4YncnuFuYrrtyHDeeOLx3wtnlN032Jpqp7An4ZK0=; h=Subject:To:Cc:From:Date:From; b=vAVlsD8KRdcLlVbe8OAxEIwPzSIRIUg9eFssJFIBSw1kSiFPMhFebk7dXvq1iqZRw 6hrDyEynG0l6eFEZrJPLbVYm+bEXH+2e98nT2mYiL7/jX8mwl/98XHRBa8/W8hvNC5 ATPxqeu8fER+DiSFPwZ3uau1mF6xGYPK8m07bC3k= Subject: FAILED: patch "[PATCH] xtensa: simdisk: add input size check in proc_write_simdisk" failed to apply to 5.4-stable tree To: linmq006@gmail.com,jcmvbkbc@gmail.com Cc: From: Date: Thu, 16 Oct 2025 14:54:07 +0200 Message-ID: <2025101607-uncivil-cartload-f9ef@gregkh> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: 8bit The patch below does not apply to the 5.4-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to . To reproduce the conflict and resubmit, you may use the following commands: git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-5.4.y git checkout FETCH_HEAD git cherry-pick -x 5d5f08fd0cd970184376bee07d59f635c8403f63 # git commit -s git send-email --to '' --in-reply-to '2025101607-uncivil-cartload-f9ef@gregkh' --subject-prefix 'PATCH 5.4.y' HEAD^.. Possible dependencies: thanks, greg k-h ------------------ original commit in Linus's tree ------------------ >From 5d5f08fd0cd970184376bee07d59f635c8403f63 Mon Sep 17 00:00:00 2001 From: Miaoqian Lin Date: Fri, 29 Aug 2025 16:30:15 +0800 Subject: [PATCH] xtensa: simdisk: add input size check in proc_write_simdisk A malicious user could pass an arbitrarily bad value to memdup_user_nul(), potentially causing kernel crash. This follows the same pattern as commit ee76746387f6 ("netdevsim: prevent bad user input in nsim_dev_health_break_write()") Fixes: b6c7e873daf7 ("xtensa: ISS: add host file-based simulated disk") Fixes: 16e5c1fc3604 ("convert a bunch of open-coded instances of memdup_user_nul()") Cc: stable@vger.kernel.org Signed-off-by: Miaoqian Lin Message-Id: <20250829083015.1992751-1-linmq006@gmail.com> Signed-off-by: Max Filippov diff --git a/arch/xtensa/platforms/iss/simdisk.c b/arch/xtensa/platforms/iss/simdisk.c index 6ed009318d24..3cafc8feddee 100644 --- a/arch/xtensa/platforms/iss/simdisk.c +++ b/arch/xtensa/platforms/iss/simdisk.c @@ -231,10 +231,14 @@ static ssize_t proc_read_simdisk(struct file *file, char __user *buf, static ssize_t proc_write_simdisk(struct file *file, const char __user *buf, size_t count, loff_t *ppos) { - char *tmp = memdup_user_nul(buf, count); + char *tmp; struct simdisk *dev = pde_data(file_inode(file)); int err; + if (count == 0 || count > PAGE_SIZE) + return -EINVAL; + + tmp = memdup_user_nul(buf, count); if (IS_ERR(tmp)) return PTR_ERR(tmp);