From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 71B34310620 for ; Thu, 16 Oct 2025 08:59:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760605193; cv=none; b=Aw0VyFIOBL2J4CDztDpGH1CwsKBipIaXlXJT1b6yRb7bAZwYphVEENWVP/o/Jf/cK/pJ29xTYrJdTwTmC4tEBVdxFfZecf5okOyyoxEOXTZYmj0prRan2FIIBOtpDNdCFmfzXfsprp0FYkRXGmtq5vYb+5vC+I78rKSaAslCGkc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760605193; c=relaxed/simple; bh=redJHUId6YBcKsFFZax77BRX8iuCmKXvTl8hZ+RGvnc=; h=Subject:To:Cc:From:Date:Message-ID:MIME-Version:Content-Type; b=eS0mGC9pHBoS+BVKQqPR0jrp+saH+UW3AjseGVQ/ZCx8HLXO5YaY0cdASNBDYE5eJvUvM7in7oLzi6IpSvFO/2fWqjYhv30rd1meDHgFB7i00K/aFwgNURANNllfB4B9b6/3TBrjZ9VHVEoLCiZWHy3mM6pT/hIYB5aYm3FB0Kk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=OIce179b; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="OIce179b" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B18BEC4CEF1; Thu, 16 Oct 2025 08:59:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1760605192; bh=redJHUId6YBcKsFFZax77BRX8iuCmKXvTl8hZ+RGvnc=; h=Subject:To:Cc:From:Date:From; b=OIce179bQqSmPDXg7yVrqDjeXzSqV8UYvk5Q8qN+4aI9saqknrgqoiEo9EpYep44S An9OU1s7wpnEXq5GWg42tQP8IrXnyVYQeauPtWcDL+AFjY67g6nOhFHoq/zD3cOyML fIZBcOfoAOQWfoXpZqcVLT+pNndAeCH6PhljLM30= Subject: FAILED: patch "[PATCH] media: cx18: Add missing check after DMA map" failed to apply to 5.10-stable tree To: fourier.thomas@gmail.com,hverkuil+cisco@kernel.org Cc: From: Date: Thu, 16 Oct 2025 10:59:41 +0200 Message-ID: <2025101641-imminent-rentable-bc13@gregkh> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: 8bit The patch below does not apply to the 5.10-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to . To reproduce the conflict and resubmit, you may use the following commands: git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-5.10.y git checkout FETCH_HEAD git cherry-pick -x 23b53639a793477326fd57ed103823a8ab63084f # git commit -s git send-email --to '' --in-reply-to '2025101641-imminent-rentable-bc13@gregkh' --subject-prefix 'PATCH 5.10.y' HEAD^.. Possible dependencies: thanks, greg k-h ------------------ original commit in Linus's tree ------------------ >From 23b53639a793477326fd57ed103823a8ab63084f Mon Sep 17 00:00:00 2001 From: Thomas Fourier Date: Wed, 9 Jul 2025 13:35:40 +0200 Subject: [PATCH] media: cx18: Add missing check after DMA map The DMA map functions can fail and should be tested for errors. If the mapping fails, dealloc buffers, and return. Fixes: 1c1e45d17b66 ("V4L/DVB (7786): cx18: new driver for the Conexant CX23418 MPEG encoder chip") Cc: stable@vger.kernel.org Signed-off-by: Thomas Fourier Signed-off-by: Hans Verkuil diff --git a/drivers/media/pci/cx18/cx18-queue.c b/drivers/media/pci/cx18/cx18-queue.c index 013694bfcb1c..7cbb2d586932 100644 --- a/drivers/media/pci/cx18/cx18-queue.c +++ b/drivers/media/pci/cx18/cx18-queue.c @@ -379,15 +379,22 @@ int cx18_stream_alloc(struct cx18_stream *s) break; } + buf->dma_handle = dma_map_single(&s->cx->pci_dev->dev, + buf->buf, s->buf_size, + s->dma); + if (dma_mapping_error(&s->cx->pci_dev->dev, buf->dma_handle)) { + kfree(buf->buf); + kfree(mdl); + kfree(buf); + break; + } + INIT_LIST_HEAD(&mdl->list); INIT_LIST_HEAD(&mdl->buf_list); mdl->id = s->mdl_base_idx; /* a somewhat safe value */ cx18_enqueue(s, mdl, &s->q_idle); INIT_LIST_HEAD(&buf->list); - buf->dma_handle = dma_map_single(&s->cx->pci_dev->dev, - buf->buf, s->buf_size, - s->dma); cx18_buf_sync_for_cpu(s, buf); list_add_tail(&buf->list, &s->buf_pool); }