From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2127C2F12A7; Fri, 17 Oct 2025 15:54:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760716498; cv=none; b=PcYZd5dyIInGnvIFlF8wlvMODcDHP6883tbmxciJO6cm8Ue0KHY7M/MJIaEul6LW/bPmJNaQ547J7V0oCE3AtDfV+dFjnBaJ22PX7djOePxEfNNyIZzFMwey897F+9IL++F3NwsqvYg+CTiyUk5NZr2XBPgCNJLGzJxVgp+3SFw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760716498; c=relaxed/simple; bh=eER2uhQccXwk8LU7DMgARBjZ7n2q9jT3I7tq66PrDQI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=K0IWcUv6Y71H4h2kdy1h+xIloqByVa8YZP17Pczsu9AMAO1JZDvMUh/xGvWFiwvID3eKI8WjSD70WQutcdukmjaKVR5HdNqqG2FsL1Vqv/eVBVLCpRerZ3DJe5G5Bolv5WS+TqjSwFkNm68x0vzMCFj54lRNJC1VbAl9S43UsF0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=ZFFrTb/1; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="ZFFrTb/1" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 69882C116C6; Fri, 17 Oct 2025 15:54:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1760716498; bh=eER2uhQccXwk8LU7DMgARBjZ7n2q9jT3I7tq66PrDQI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ZFFrTb/1Vfp3DNaoHelyE0Q3IO0XmWVVnme5hK+ofRsdfY/oSCu/y5GQ6YebyBLj+ Wve8eo5JChPnz05K7r8RA+0M8st2+vVSbEwkM9VaASvkGfIC6S41vicLCGf+0fkPKB EJcAaiOKUS6lEfkWoa28yo2Lj5bgG6WEXP20f4L0= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Jiri Slaby , Siddharth Vadapalli , Manivannan Sadhasivam Subject: [PATCH 5.15 210/276] PCI: keystone: Use devm_request_irq() to free "ks-pcie-error-irq" on exit Date: Fri, 17 Oct 2025 16:55:03 +0200 Message-ID: <20251017145150.131061399@linuxfoundation.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251017145142.382145055@linuxfoundation.org> References: <20251017145142.382145055@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.15-stable review patch. If anyone has any objections, please let me know. ------------------ From: Siddharth Vadapalli commit e51d05f523e43ce5d2bad957943a2b14f68078cd upstream. Commit under Fixes introduced the IRQ handler for "ks-pcie-error-irq". The interrupt is acquired using "request_irq()" but is never freed if the driver exits due to an error. Although the section in the driver that invokes "request_irq()" has moved around over time, the issue hasn't been addressed until now. Fix this by using "devm_request_irq()" which automatically frees the interrupt if the driver exits. Fixes: 025dd3daeda7 ("PCI: keystone: Add error IRQ handler") Reported-by: Jiri Slaby Closes: https://lore.kernel.org/r/3d3a4b52-e343-42f3-9d69-94c259812143@kernel.org Signed-off-by: Siddharth Vadapalli Signed-off-by: Manivannan Sadhasivam Cc: stable@vger.kernel.org Link: https://patch.msgid.link/20250912100802.3136121-2-s-vadapalli@ti.com Signed-off-by: Greg Kroah-Hartman --- drivers/pci/controller/dwc/pci-keystone.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/drivers/pci/controller/dwc/pci-keystone.c +++ b/drivers/pci/controller/dwc/pci-keystone.c @@ -1200,8 +1200,8 @@ static int ks_pcie_probe(struct platform if (irq < 0) return irq; - ret = request_irq(irq, ks_pcie_err_irq_handler, IRQF_SHARED, - "ks-pcie-error-irq", ks_pcie); + ret = devm_request_irq(dev, irq, ks_pcie_err_irq_handler, IRQF_SHARED, + "ks-pcie-error-irq", ks_pcie); if (ret < 0) { dev_err(dev, "failed to request error IRQ %d\n", irq);