From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 728B728935A; Fri, 17 Oct 2025 15:29:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760714990; cv=none; b=h99lvE9R8Ejt1zEIoS77TZvP0y2HC3SJ6QRLFNP/+l97oGVrl5DB73/8wIeVlmSu048r3j03CUrYhHFHccUYk7RRzEfeKWgDAY8PC/27BT/67LmJefnrE2IP8Gl4hrN6SYWwSE4nV6pt4YukDgCJYVAZuOPpyTCWogjq/L5EWU4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760714990; c=relaxed/simple; bh=UX/Ske3T4oqx8UwEFw1YygNo4rMZSYRB6NYd2Sw8aqU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=BI4JUc0m/qHqSYk2UIDM9iJJjy7beBmBINCnQIEd/OQEkegNtbabx0sGvEHRVFFYjjgKeD4caP8EUKblix7MmBbK7ED6YvnTGVnfD9fP+nO07HNGnDw0Ps/EmH7Oc/4HHS5OXx4ZIBG8lvePCRKvFD9U8Zhziqr92tunMwEeSgM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=g7deEIks; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="g7deEIks" Received: by smtp.kernel.org (Postfix) with ESMTPSA id BE927C4CEFE; Fri, 17 Oct 2025 15:29:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1760714990; bh=UX/Ske3T4oqx8UwEFw1YygNo4rMZSYRB6NYd2Sw8aqU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=g7deEIkszUf8xtesz9fyXjUcVBybsOV0AaKHEQK7LnmITLiJ+FIgj6LhpbJAN/+BZ KdkhEwo/77iPgoO58PC1H/NNEi3PcN0NFgb/A0E37uEHoGYQDA8iV3jf4YPAIl2Z0+ fhDEPgBxoPbN3QgYjEj9vC85OXOF+C0TapipbviA= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, James Clark , Ian Rogers , Namhyung Kim , Adrian Hunter , Alexander Shishkin , Athira Rajeev , Blake Jones , Chun-Tse Shao , Collin Funk , Howard Chu , Ingo Molnar , Jan Polensky , Jiri Olsa , Kan Liang , Li Huafei , Mark Rutland , Nam Cao , Peter Zijlstra , "Steinar H. Gunderson" , Thomas Gleixner , Arnaldo Carvalho de Melo , Sasha Levin Subject: [PATCH 6.17 027/371] perf evsel: Avoid container_of on a NULL leader Date: Fri, 17 Oct 2025 16:50:02 +0200 Message-ID: <20251017145202.781439671@linuxfoundation.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251017145201.780251198@linuxfoundation.org> References: <20251017145201.780251198@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.17-stable review patch. If anyone has any objections, please let me know. ------------------ From: Ian Rogers [ Upstream commit 2354479026d726954ff86ce82f4b649637319661 ] An evsel should typically have a leader of itself, however, in tests like 'Sample parsing' a NULL leader may occur and the container_of will return a corrupt pointer. Avoid this with an explicit NULL test. Fixes: fba7c86601e2e42d ("libperf: Move 'leader' from tools/perf to perf_evsel::leader") Reviewed-by: James Clark Signed-off-by: Ian Rogers Acked-by: Namhyung Kim Cc: Adrian Hunter Cc: Alexander Shishkin Cc: Athira Rajeev Cc: Blake Jones Cc: Chun-Tse Shao Cc: Collin Funk Cc: Howard Chu Cc: Ingo Molnar Cc: Jan Polensky Cc: Jiri Olsa Cc: Kan Liang Cc: Li Huafei Cc: Mark Rutland Cc: Nam Cao Cc: Peter Zijlstra Cc: Steinar H. Gunderson Cc: Thomas Gleixner Link: https://lore.kernel.org/r/20250821163820.1132977-4-irogers@google.com Signed-off-by: Arnaldo Carvalho de Melo Signed-off-by: Sasha Levin --- tools/perf/util/evsel.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c index d264c143b5925..496f42434327b 100644 --- a/tools/perf/util/evsel.c +++ b/tools/perf/util/evsel.c @@ -3935,6 +3935,8 @@ bool evsel__is_hybrid(const struct evsel *evsel) struct evsel *evsel__leader(const struct evsel *evsel) { + if (evsel->core.leader == NULL) + return NULL; return container_of(evsel->core.leader, struct evsel, core); } -- 2.51.0