From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A08573328EE; Fri, 17 Oct 2025 15:32:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760715156; cv=none; b=Vj5Y3HATN4lGeXT72LG4VMw4LyckGof3Smnqy8bD4Op0XvezWI1uQ6WTM8pN64pprAbZ4I/QpHArjqt8/3IkIBLBVtr7Ms+k939vH5mgBZAWlrtwzBggnSY2DhKW2gqcsGdfVp+75zMaLts+hVGqTEGqvUVsAJYUbkU+zNN8ICY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760715156; c=relaxed/simple; bh=ftikmk450lt8bCsvaL4Hi6L5NA2ywVA9BoxPutYMRMM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=PfY+QzNfLd1RsTSQ13EvsjKsGb6g23XAAC5VueGV57k+wN5uOxyI3t+VFRv3U8axYwFZqICNYkKM1mUCwq9NPAdRi57wEbWqdf8plSaiqZBqKQC2AutllbQb97FU1783yrYhiMnt0qsE/ZgRsmn/LlPpHbNVnqywUbiDegQaI/g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=ncqjLboL; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="ncqjLboL" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2CA07C4CEFE; Fri, 17 Oct 2025 15:32:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1760715156; bh=ftikmk450lt8bCsvaL4Hi6L5NA2ywVA9BoxPutYMRMM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ncqjLboLL8xfw//jM2Dw4oT8jGb5qkTH+SMkEgE5FfXTnBTnO2DJOIjYXHdL4CTBN MyBVrXfMz+mWq/DqbZqKZkr/E2hlxP0ozKL1bRjpb5SMf0DESp+/CSDfm5Mw1s3w4W O3jgsduZcGNs1plpYIeesvEieeS4qi4V3n9oQhYQ= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Eric Woudstra , Florian Westphal , Sasha Levin Subject: [PATCH 6.17 117/371] bridge: br_vlan_fill_forward_path_pvid: use br_vlan_group_rcu() Date: Fri, 17 Oct 2025 16:51:32 +0200 Message-ID: <20251017145206.168766225@linuxfoundation.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251017145201.780251198@linuxfoundation.org> References: <20251017145201.780251198@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.17-stable review patch. If anyone has any objections, please let me know. ------------------ From: Eric Woudstra [ Upstream commit bbf0c98b3ad9edaea1f982de6c199cc11d3b7705 ] net/bridge/br_private.h:1627 suspicious rcu_dereference_protected() usage! other info that might help us debug this: rcu_scheduler_active = 2, debug_locks = 1 7 locks held by socat/410: #0: ffff88800d7a9c90 (sk_lock-AF_INET){+.+.}-{0:0}, at: inet_stream_connect+0x43/0xa0 #1: ffffffff9a779900 (rcu_read_lock){....}-{1:3}, at: __ip_queue_xmit+0x62/0x1830 [..] #6: ffffffff9a779900 (rcu_read_lock){....}-{1:3}, at: nf_hook.constprop.0+0x8a/0x440 Call Trace: lockdep_rcu_suspicious.cold+0x4f/0xb1 br_vlan_fill_forward_path_pvid+0x32c/0x410 [bridge] br_fill_forward_path+0x7a/0x4d0 [bridge] Use to correct helper, non _rcu variant requires RTNL mutex. Fixes: bcf2766b1377 ("net: bridge: resolve forwarding path for VLAN tag actions in bridge devices") Signed-off-by: Eric Woudstra Signed-off-by: Florian Westphal Signed-off-by: Sasha Levin --- net/bridge/br_vlan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/bridge/br_vlan.c b/net/bridge/br_vlan.c index 939a3aa78d5c4..54993a05037c1 100644 --- a/net/bridge/br_vlan.c +++ b/net/bridge/br_vlan.c @@ -1455,7 +1455,7 @@ void br_vlan_fill_forward_path_pvid(struct net_bridge *br, if (!br_opt_get(br, BROPT_VLAN_ENABLED)) return; - vg = br_vlan_group(br); + vg = br_vlan_group_rcu(br); if (idx >= 0 && ctx->vlan[idx].proto == br->vlan_proto) { -- 2.51.0