From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DDF1D32C957; Fri, 17 Oct 2025 15:37:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760715453; cv=none; b=SjvfL/By+5OzkagGMfetna72lITGHYriphneDP39h1b81tABtf381015gMwaeRxDMo8Smr2SPhZC9M8kZviH5lixto6/Tbk4dT2NJGTW+dzBy9V1ZvKVOeR/0LzGkhVMYDOH4pb7IgUZqBuoFmwTcPwtnoGYULaj01qi15w8U0E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760715453; c=relaxed/simple; bh=jAOCkGS4FbCFgCCWWPgLwvYvTKMpPSJJzwY3PxRtE/8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=NI56/K+/xzSkIHWqVyq3l9WyWUECXXDC5FkmOmwrGm1oYKYiFB5WYYqsJK/O2nPcOgoVfZ2q0oT23Ui4C4OeVmjkA5AJ9ndlzkz16hBqF2RuI1aWE038YsbHi5f1OUq3v1L7p20DR8R9ZaJGzlqIhD38yGICkUwx/mc+YDbNdxs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=tJ0sDplL; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="tJ0sDplL" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2978FC4CEE7; Fri, 17 Oct 2025 15:37:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1760715452; bh=jAOCkGS4FbCFgCCWWPgLwvYvTKMpPSJJzwY3PxRtE/8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=tJ0sDplLJlk5zWu75OV7PFJhm/fjEbXNAoD8jb2pnb2tlCgTMJufVKbkw0SeDTwla sySaIIF8AMZmbGCFGhdDetQGrdAqj/ex0APMo5orgmTR4M7vPr8WfbmSfpa2l8P4X7 iLpxtKKPRvG360d7zLoehGPXXWxT1ia66UIe1n7k= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Qianfeng Rong , Andy Shevchenko , Stable@vger.kernel.org, Jonathan Cameron Subject: [PATCH 6.17 221/371] iio: dac: ad5421: use int type to store negative error codes Date: Fri, 17 Oct 2025 16:53:16 +0200 Message-ID: <20251017145210.082606919@linuxfoundation.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251017145201.780251198@linuxfoundation.org> References: <20251017145201.780251198@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.17-stable review patch. If anyone has any objections, please let me know. ------------------ From: Qianfeng Rong commit 3379c900320954d768ed9903691fb2520926bbe3 upstream. Change the 'ret' variable in ad5421_update_ctrl() from unsigned int to int, as it needs to store either negative error codes or zero returned by ad5421_write_unlocked(). Fixes: 5691b23489db ("staging:iio:dac: Add AD5421 driver") Signed-off-by: Qianfeng Rong Reviewed-by: Andy Shevchenko Link: https://patch.msgid.link/20250901135726.17601-3-rongqianfeng@vivo.com Cc: Signed-off-by: Jonathan Cameron Signed-off-by: Greg Kroah-Hartman --- drivers/iio/dac/ad5421.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/iio/dac/ad5421.c +++ b/drivers/iio/dac/ad5421.c @@ -186,7 +186,7 @@ static int ad5421_update_ctrl(struct iio unsigned int clr) { struct ad5421_state *st = iio_priv(indio_dev); - unsigned int ret; + int ret; mutex_lock(&st->lock);