From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D2B0D20C00A; Fri, 17 Oct 2025 15:44:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760715866; cv=none; b=IQAC3gBsGBvEaCh1itnUEcKOGJLoUcQRV729jH9fp7dxg24hZU3tOc9vaGogtzI+QLrUK9HVJTToAAlPI7e7qAZmJx0CrXsANbpMP6ZVXWrm+CZ0NEsVDkoF+R9kChhNihlO0WGeJ8N/nlkQZRoctyUZebHg0SdrZl4m7BKOnIM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760715866; c=relaxed/simple; bh=4kI1T1PupbOMB+BRfO9WihJEYBgVwzJUE0yUkaG9wjo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=DFrVUPQXKXCRROL42Cd+brWoxnlkJVfc37sfACplugFrZjSwjmePiwI9/kxPMxWaGi0fzOmTfToH0oweuxQXg5uDUAapxRMIs75Pms7HDsqCTS/32NnkIpTp+kqJjqjcR5ZVa0rTj8J/KNGDsnhBRfFPhQumQAkjdDF7H46oJuk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=OhkrUAJ8; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="OhkrUAJ8" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 13028C4CEFE; Fri, 17 Oct 2025 15:44:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1760715866; bh=4kI1T1PupbOMB+BRfO9WihJEYBgVwzJUE0yUkaG9wjo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=OhkrUAJ8cT8ZdXFdDw0+YR2+vOqXkOzSjN8if8Z/G5m1VCiXgfMMbl2m80eKJo7sF /5Nj2pUuIZ4Ht46gjcAaNVxsOae9SCY0z1m64RXCSahMKUqhDT0Mit2qWPs5mjqOzI 7YCJPEuVxgfPrgMUR3Wwvamn9S0t58T7jzCPEIQg= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, syzbot , Tetsuo Handa , Nicolas Pitre , Christian Brauner , Sasha Levin Subject: [PATCH 6.17 364/371] cramfs: Verify inode mode when loading from disk Date: Fri, 17 Oct 2025 16:55:39 +0200 Message-ID: <20251017145215.257209742@linuxfoundation.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251017145201.780251198@linuxfoundation.org> References: <20251017145201.780251198@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.17-stable review patch. If anyone has any objections, please let me know. ------------------ From: Tetsuo Handa [ Upstream commit 7f9d34b0a7cb93d678ee7207f0634dbf79e47fe5 ] The inode mode loaded from corrupted disk can be invalid. Do like what commit 0a9e74051313 ("isofs: Verify inode mode when loading from disk") does. Reported-by: syzbot Closes: https://syzkaller.appspot.com/bug?extid=895c23f6917da440ed0d Signed-off-by: Tetsuo Handa Link: https://lore.kernel.org/429b3ef1-13de-4310-9a8e-c2dc9a36234a@I-love.SAKURA.ne.jp Acked-by: Nicolas Pitre Signed-off-by: Christian Brauner Signed-off-by: Sasha Levin --- fs/cramfs/inode.c | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/fs/cramfs/inode.c b/fs/cramfs/inode.c index 56c8005b24a34..ca54bf24b719f 100644 --- a/fs/cramfs/inode.c +++ b/fs/cramfs/inode.c @@ -116,9 +116,18 @@ static struct inode *get_cramfs_inode(struct super_block *sb, inode_nohighmem(inode); inode->i_data.a_ops = &cramfs_aops; break; - default: + case S_IFCHR: + case S_IFBLK: + case S_IFIFO: + case S_IFSOCK: init_special_inode(inode, cramfs_inode->mode, old_decode_dev(cramfs_inode->size)); + break; + default: + printk(KERN_DEBUG "CRAMFS: Invalid file type 0%04o for inode %lu.\n", + inode->i_mode, inode->i_ino); + iget_failed(inode); + return ERR_PTR(-EIO); } inode->i_mode = cramfs_inode->mode; -- 2.51.0