From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B9F22248883 for ; Mon, 20 Oct 2025 12:57:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760965021; cv=none; b=eIB/kRo3WCF9VGlJaHf1zEhEVkMcUlN4Dj4PTK1x9MqqhP0oFF6n7Jx0Vkukp2tpkK0YLk3NUV+RaVfujxh8fgiTDa0X/jfIudm++y7Mxdf5lbrfE8LY8YGsJRDTmcWTbmp6SS0Bdulrsq+H7lkxr9MXv7Zr272VA5fhtkBi9hk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760965021; c=relaxed/simple; bh=7HOJYC2yxBBswwXkbLIUjerql+cX/N2tw9f7efGvQ0A=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=AftSb1bCZHHX0ot8fGjNUf4IDUNlonc7og+i45Sj+24qnJ4CUxB/tu2pvioGbVqfAK6VylCItyba8cx05cU8PrkL3B0UV6NNtUqX8V9mvQ8LYHykvlX0qKNg6D8i1nSytPgviPkW9gvF78oaT57jZU8fXmXyv+FdcYtKsrkpE6s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=m3urDW6I; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="m3urDW6I" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6205BC116C6; Mon, 20 Oct 2025 12:57:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1760965021; bh=7HOJYC2yxBBswwXkbLIUjerql+cX/N2tw9f7efGvQ0A=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=m3urDW6IAw3QjNf+Wo3zZiwxOHdE9qPCJClj099Ibj+HfXD30ijk7uLuHq00Cf3/s X5HBKsQLrZhL9IxD06tOyq7vE6MP8SJtpjCnaIx/IMBs7QHzJfebISdvAqkJ3ZVSgx L8tP7d9GIDZ52n2m+8s0QDP/OQXjXmBFAgGBxl6buBGr6VhLNpgwsq+KgNgHpbnDT4 grZstAEoRZWw5T5E6VnM9qyCySHqwRyENIK8LKBahy6mfOLUlINJZ8oKIhSXyLpLE+ VfUgF28MiGJwZorFsyTFb33utNGlPMi/6MTUia2STQwEAlwmnTa/DYwxclcL+zvPCr zpPD6KVf64VbA== From: Sasha Levin To: stable@vger.kernel.org Cc: Sergey Bashirov , Konstantin Evtushenko , Christoph Hellwig , Jeff Layton , Chuck Lever , Sasha Levin Subject: [PATCH 5.10.y 3/3] NFSD: Fix last write offset handling in layoutcommit Date: Mon, 20 Oct 2025 08:56:56 -0400 Message-ID: <20251020125656.1761732-3-sashal@kernel.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251020125656.1761732-1-sashal@kernel.org> References: <2025101659-wing-paltry-7e9d@gregkh> <20251020125656.1761732-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Sergey Bashirov [ Upstream commit d68886bae76a4b9b3484d23e5b7df086f940fa38 ] The data type of loca_last_write_offset is newoffset4 and is switched on a boolean value, no_newoffset, that indicates if a previous write occurred or not. If no_newoffset is FALSE, an offset is not given. This means that client does not try to update the file size. Thus, server should not try to calculate new file size and check if it fits into the segment range. See RFC 8881, section 12.5.4.2. Sometimes the current incorrect logic may cause clients to hang when trying to sync an inode. If layoutcommit fails, the client marks the inode as dirty again. Fixes: 9cf514ccfacb ("nfsd: implement pNFS operations") Cc: stable@vger.kernel.org Co-developed-by: Konstantin Evtushenko Signed-off-by: Konstantin Evtushenko Signed-off-by: Sergey Bashirov Reviewed-by: Christoph Hellwig Reviewed-by: Jeff Layton Signed-off-by: Chuck Lever [ removed rqstp parameter from proc_layoutcommit ] Signed-off-by: Sasha Levin --- fs/nfsd/blocklayout.c | 5 ++--- fs/nfsd/nfs4proc.c | 30 +++++++++++++++--------------- 2 files changed, 17 insertions(+), 18 deletions(-) diff --git a/fs/nfsd/blocklayout.c b/fs/nfsd/blocklayout.c index d91a686d2f313..aa9b7ae59a076 100644 --- a/fs/nfsd/blocklayout.c +++ b/fs/nfsd/blocklayout.c @@ -121,7 +121,6 @@ static __be32 nfsd4_block_commit_blocks(struct inode *inode, struct nfsd4_layoutcommit *lcp, struct iomap *iomaps, int nr_iomaps) { - loff_t new_size = lcp->lc_last_wr + 1; struct iattr iattr = { .ia_valid = 0 }; int error; @@ -131,9 +130,9 @@ nfsd4_block_commit_blocks(struct inode *inode, struct nfsd4_layoutcommit *lcp, iattr.ia_valid |= ATTR_ATIME | ATTR_CTIME | ATTR_MTIME; iattr.ia_atime = iattr.ia_ctime = iattr.ia_mtime = lcp->lc_mtime; - if (new_size > i_size_read(inode)) { + if (lcp->lc_size_chg) { iattr.ia_valid |= ATTR_SIZE; - iattr.ia_size = new_size; + iattr.ia_size = lcp->lc_newsize; } error = inode->i_sb->s_export_op->commit_blocks(inode, iomaps, diff --git a/fs/nfsd/nfs4proc.c b/fs/nfsd/nfs4proc.c index 3353bc2e3d0ef..908143cac5b46 100644 --- a/fs/nfsd/nfs4proc.c +++ b/fs/nfsd/nfs4proc.c @@ -2262,7 +2262,6 @@ nfsd4_layoutcommit(struct svc_rqst *rqstp, const struct nfsd4_layout_seg *seg = &lcp->lc_seg; struct svc_fh *current_fh = &cstate->current_fh; const struct nfsd4_layout_ops *ops; - loff_t new_size = lcp->lc_last_wr + 1; struct inode *inode; struct nfs4_layout_stateid *ls; __be32 nfserr; @@ -2277,13 +2276,21 @@ nfsd4_layoutcommit(struct svc_rqst *rqstp, goto out; inode = d_inode(current_fh->fh_dentry); - nfserr = nfserr_inval; - if (new_size <= seg->offset) - goto out; - if (new_size > seg->offset + seg->length) - goto out; - if (!lcp->lc_newoffset && new_size > i_size_read(inode)) - goto out; + lcp->lc_size_chg = false; + if (lcp->lc_newoffset) { + loff_t new_size = lcp->lc_last_wr + 1; + + nfserr = nfserr_inval; + if (new_size <= seg->offset) + goto out; + if (new_size > seg->offset + seg->length) + goto out; + + if (new_size > i_size_read(inode)) { + lcp->lc_size_chg = true; + lcp->lc_newsize = new_size; + } + } nfserr = nfsd4_preprocess_layout_stateid(rqstp, cstate, &lcp->lc_sid, false, lcp->lc_layout_type, @@ -2299,13 +2306,6 @@ nfsd4_layoutcommit(struct svc_rqst *rqstp, /* LAYOUTCOMMIT does not require any serialization */ mutex_unlock(&ls->ls_mutex); - if (new_size > i_size_read(inode)) { - lcp->lc_size_chg = 1; - lcp->lc_newsize = new_size; - } else { - lcp->lc_size_chg = 0; - } - nfserr = ops->proc_layoutcommit(inode, lcp); nfs4_put_stid(&ls->ls_stid); out: -- 2.51.0