From: Mario Limonciello <mario.limonciello@amd.com>
To: <mario.limonciello@amd.com>, <amd-gfx@lists.freedesktop.org>
Cc: <stable@vger.kernel.org>, Sultan Alsawaf <sultan@kerneltoast.com>
Subject: [PATCH] drm/amd: Add missing return for VPE idle handler
Date: Mon, 20 Oct 2025 17:34:34 -0500 [thread overview]
Message-ID: <20251020223434.5977-1-mario.limonciello@amd.com> (raw)
Adjusting the idle handler for DPM0 handling forgot a return statement
which causes the system to not be able to enter s0i3.
Add the missing return statement.
Cc: stable@vger.kernel.org
Reported-by: Sultan Alsawaf <sultan@kerneltoast.com>
Closes: https://lore.kernel.org/amd-gfx/aPawCXBY9eM8oZvG@sultan-box/
Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vpe.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vpe.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vpe.c
index f4932339d79d..aa78c2ee9e21 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vpe.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vpe.c
@@ -356,6 +356,7 @@ static void vpe_idle_work_handler(struct work_struct *work)
goto reschedule;
amdgpu_device_ip_set_powergating_state(adev, AMD_IP_BLOCK_TYPE_VPE, AMD_PG_STATE_GATE);
+ return;
reschedule:
schedule_delayed_work(&adev->vpe.idle_work, VPE_IDLE_TIMEOUT);
--
2.49.0
next reply other threads:[~2025-10-20 22:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-20 22:34 Mario Limonciello [this message]
2025-10-20 22:36 ` [PATCH] drm/amd: Add missing return for VPE idle handler Alex Deucher
2025-10-20 22:38 ` Sultan Alsawaf
2025-10-20 22:42 ` Sultan Alsawaf
2025-10-20 22:45 ` Sultan Alsawaf
2025-10-21 20:25 ` Mario Limonciello
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251020223434.5977-1-mario.limonciello@amd.com \
--to=mario.limonciello@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=stable@vger.kernel.org \
--cc=sultan@kerneltoast.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox