From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D2B2934D900 for ; Tue, 21 Oct 2025 18:37:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761071845; cv=none; b=o4eVNETRT4e6RaVJzQGTawDYe09P5YHLqybnLSa7qiiyf9tO16bYPVr2gG5uHKkRdyEVDLpoo8dOOrMee+iOklpbhymGpsJ31EwUJ/+QhOb8YFuil5v/CnG42wbBEGs2WDVT89XU3A7eSOr4izNNVYu1LUBVgbKVrduD6VsY6H4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761071845; c=relaxed/simple; bh=1QEb0CqG9+vuTU1O9Ao2Z331nATk0wGOxUBxe2NYplc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=q5Tu+/nnAFkR2qmlvYKPUtq5a6Z8xSozsEsu6gFcT12cGy1CvvH3Mq+qADs3QIBUQ9ksvFtKN2+Z/2Ak5ItYcz1CoWvaCaL4oTBYak09SNt++ATqQ+BBpD78vA+VkUgM4d2odk4HAY4mrsctF1jXspUg4A+YW4ntpRlqR4c4wZs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=grLDOAI7; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="grLDOAI7" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C9A0FC113D0; Tue, 21 Oct 2025 18:37:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1761071845; bh=1QEb0CqG9+vuTU1O9Ao2Z331nATk0wGOxUBxe2NYplc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=grLDOAI74H1rlq7YVkET5AtOxEwKNklAojeUC5UE4RF3Jfhltl3evrkCFJR1pAl1L 8H+jmjTw3Ul/73vgeeiSqXrsYtdowS+qbko7e3+nkgXr2h6+c5hJZ+eYL7iZgP5i9e WNzNlv3XIlPbAFajAugH3lK286/vHNvJqCmIIUhPPW4DHQcZoNGIDFN98+8iLIO5Qo vaLbcsISJI7fhWdDy4drL0Y/RaZs7O2yfmsK14PLfnH1pvqCUK+FVfzgpiuFTbFMSw PRqXtfoN2K/aXESwfCQ5TdYBGzAfYB2WZH6UACDAzakspD9Dmh0ZecA0kc+u1AE/px b9BKc3fG9o2Ng== From: Sasha Levin To: stable@vger.kernel.org Cc: Siddharth Vadapalli , Manivannan Sadhasivam , Sasha Levin Subject: [PATCH 6.6.y 2/2] PCI: j721e: Fix programming sequence of "strap" settings Date: Tue, 21 Oct 2025 14:37:22 -0400 Message-ID: <20251021183722.2520843-2-sashal@kernel.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251021183722.2520843-1-sashal@kernel.org> References: <2025101614-regulator-gumball-c7c6@gregkh> <20251021183722.2520843-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Siddharth Vadapalli [ Upstream commit f842d3313ba179d4005096357289c7ad09cec575 ] The Cadence PCIe Controller integrated in the TI K3 SoCs supports both Root-Complex and Endpoint modes of operation. The Glue Layer allows "strapping" the Mode of operation of the Controller, the Link Speed and the Link Width. This is enabled by programming the "PCIEn_CTRL" register (n corresponds to the PCIe instance) within the CTRL_MMR memory-mapped register space. The "reset-values" of the registers are also different depending on the mode of operation. Since the PCIe Controller latches onto the "reset-values" immediately after being powered on, if the Glue Layer configuration is not done while the PCIe Controller is off, it will result in the PCIe Controller latching onto the wrong "reset-values". In practice, this will show up as a wrong representation of the PCIe Controller's capability structures in the PCIe Configuration Space. Some such capabilities which are supported by the PCIe Controller in the Root-Complex mode but are incorrectly latched onto as being unsupported are: - Link Bandwidth Notification - Alternate Routing ID (ARI) Forwarding Support - Next capability offset within Advanced Error Reporting (AER) capability Fix this by powering off the PCIe Controller before programming the "strap" settings and powering it on after that. The runtime PM APIs namely pm_runtime_put_sync() and pm_runtime_get_sync() will decrement and increment the usage counter respectively, causing GENPD to power off and power on the PCIe Controller. Fixes: f3e25911a430 ("PCI: j721e: Add TI J721E PCIe driver") Signed-off-by: Siddharth Vadapalli Signed-off-by: Manivannan Sadhasivam Cc: stable@vger.kernel.org Link: https://patch.msgid.link/20250908120828.1471776-1-s-vadapalli@ti.com Signed-off-by: Sasha Levin --- drivers/pci/controller/cadence/pci-j721e.c | 25 ++++++++++++++++++++++ 1 file changed, 25 insertions(+) diff --git a/drivers/pci/controller/cadence/pci-j721e.c b/drivers/pci/controller/cadence/pci-j721e.c index 28da514bfa128..753a4c615781f 100644 --- a/drivers/pci/controller/cadence/pci-j721e.c +++ b/drivers/pci/controller/cadence/pci-j721e.c @@ -277,6 +277,25 @@ static int j721e_pcie_ctrl_init(struct j721e_pcie *pcie) if (!ret) offset = args.args[0]; + /* + * The PCIe Controller's registers have different "reset-values" + * depending on the "strap" settings programmed into the PCIEn_CTRL + * register within the CTRL_MMR memory-mapped register space. + * The registers latch onto a "reset-value" based on the "strap" + * settings sampled after the PCIe Controller is powered on. + * To ensure that the "reset-values" are sampled accurately, power + * off the PCIe Controller before programming the "strap" settings + * and power it on after that. The runtime PM APIs namely + * pm_runtime_put_sync() and pm_runtime_get_sync() will decrement and + * increment the usage counter respectively, causing GENPD to power off + * and power on the PCIe Controller. + */ + ret = pm_runtime_put_sync(dev); + if (ret < 0) { + dev_err(dev, "Failed to power off PCIe Controller\n"); + return ret; + } + ret = j721e_pcie_set_mode(pcie, syscon, offset); if (ret < 0) { dev_err(dev, "Failed to set pci mode\n"); @@ -295,6 +314,12 @@ static int j721e_pcie_ctrl_init(struct j721e_pcie *pcie) return ret; } + ret = pm_runtime_get_sync(dev); + if (ret < 0) { + dev_err(dev, "Failed to power on PCIe Controller\n"); + return ret; + } + /* Enable ACSPCIE refclk output if the optional property exists */ syscon = syscon_regmap_lookup_by_phandle_optional(node, "ti,syscon-acspcie-proxy-ctrl"); -- 2.51.0