From: Petr Vorel <pvorel@suse.cz>
To: Ville Syrjala <ville.syrjala@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org,
stable@vger.kernel.org
Subject: Re: [PATCH 1/3] drm/i915/dmc: Clear HRR EVT_CTL/HTP to zero on ADL-S
Date: Wed, 22 Oct 2025 13:21:13 +0200 [thread overview]
Message-ID: <20251022112113.GA476500@pevik> (raw)
In-Reply-To: <20251022100718.24803-2-ville.syrjala@linux.intel.com>
Hi Ville,
> On ADL-S the main DMC HRR event DMC_EVT_CTL/HTP are never
> restored to their previous values during DC6 exit. This
> angers assert_dmc_loaded(), and basically makes the HRR
> handler unusable because we don't rewrite EVT_HTP when
> enabling DMC events.
> Let's just clear the HRR EVT_CTL/HTP to zero from the
> beginnning so that the expected value matches the post-DC6
> reality.
> I suppose if we ever had actual use for HRR we'd have to both,
> reject HRR+PSR, and reprogram EVT_HTP when enabling the event.
> But for now we don't care about HRR so keeping both registers
> zeroed is fine.
...
LGTM.
Reviewed-by: Petr Vorel <pvorel@suse.cz>
Kind regards,
Petr
prev parent reply other threads:[~2025-10-22 11:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20251022100718.24803-1-ville.syrjala@linux.intel.com>
2025-10-22 10:07 ` [PATCH 1/3] drm/i915/dmc: Clear HRR EVT_CTL/HTP to zero on ADL-S Ville Syrjala
2025-10-22 11:21 ` Petr Vorel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251022112113.GA476500@pevik \
--to=pvorel@suse.cz \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=stable@vger.kernel.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox