[PATCH 5.10.y] firewire: net: fix use after free in fwnet_finish_incoming_packet()

[PATCH 5.10.y] firewire: net: fix use after free in fwnet_finish_incoming_packet()

[Vasiliy Kovalev]

From: Zhang Shurong <zhang_shurong@foxmail.com>

commit 3ff256751a2853e1ffaa36958ff933ccc98c6cb5 upstream.

The netif_rx() function frees the skb so we can't dereference it to
save the skb->len.

Signed-off-by: Zhang Shurong <zhang_shurong@foxmail.com>
Link: https://lore.kernel.org/r/tencent_3B3D24B66ED66A6BB73CC0E63C6A14E45109@qq.com
Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
[ kovalev: bp to fix CVE-2023-53432 ]
Signed-off-by: Vasiliy Kovalev <kovalev@altlinux.org>
---
 drivers/firewire/net.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/firewire/net.c b/drivers/firewire/net.c
index 715e491dfbc3..8504e95ede90 100644
--- a/drivers/firewire/net.c
+++ b/drivers/firewire/net.c
@@ -489,7 +489,7 @@ static int fwnet_finish_incoming_packet(struct net_device *net,
 					bool is_broadcast, u16 ether_type)
 {
 	struct fwnet_device *dev;
-	int status;
+	int status, len;
 	__be64 guid;
 
 	switch (ether_type) {
@@ -546,13 +546,15 @@ static int fwnet_finish_incoming_packet(struct net_device *net,
 		}
 		skb->protocol = protocol;
 	}
+
+	len = skb->len;
 	status = netif_rx(skb);
 	if (status == NET_RX_DROP) {
 		net->stats.rx_errors++;
 		net->stats.rx_dropped++;
 	} else {
 		net->stats.rx_packets++;
-		net->stats.rx_bytes += skb->len;
+		net->stats.rx_bytes += len;
 	}
 
 	return 0;
-- 
2.50.1