From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0942E218AB4 for ; Sun, 26 Oct 2025 16:25:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761495933; cv=none; b=Sr1jznQNb7UoOb2CZ+gjluDX6IBnR8SmmjSsAYje5q04FaVPQUZkday5FAmZFxpbYVkYkarcLeu7kx1Y8Avw65iI7kRNu1I7DkObDKCUYhmwDOPxwEEgUAwi6uUIT8ULVPRDwrRmpGrGXBNPCT5wQ/zZYfn9mA5zvhyLCmVAUvo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761495933; c=relaxed/simple; bh=iw4Ig86xLWeyC0pu6prZYaNR1jyK4JxDqbS2XjwUyrY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=H0LpFz7nMqeQw87JKIOcqSN8k/HDK+dIzvkmUlfChVtL//z5ZALNt9VjMgXoFT7bhuFpI/YK6/iqXmn1GBwsvzl1gNZ9gp2sKTW943MMYDrt9lyN0m/gheh8pPbgf+vOboPf/SRDTSK0KiGJ2Dnmr1PsgAZgaidNHziPtBTUzfA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=kRcyaJKG; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="kRcyaJKG" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D266AC4CEE7; Sun, 26 Oct 2025 16:25:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1761495931; bh=iw4Ig86xLWeyC0pu6prZYaNR1jyK4JxDqbS2XjwUyrY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=kRcyaJKGsfIH2OoxP0n08cZXZsDUmM1xWg6GXoKV+S636dFM7vuCoyNsyTcEW2+Vt bgVkrt4oc+0YLYx9FgPvInZBqm7t1ZpmRCjOu3WXFw26Lc98ECpwH88fiqYe0Jvgh1 kxHfbDEg5O159viukwQ1bJxbW2bj79qeHKKDEBly5bmyjAie362WFwIK78sFeoG+NW X8BaCzwO1x7rDzBPJQZl6eEstuSwiqlHIVdEDo3iymT/MQp0kyleEeifgGbv8ipdVS qSjdf0XrBJb3vXCg64BLV6VBx1BmPvno6sTnlIb+lhOkge1aKvvxKSkUibVvcEvFTt jMntEveTY92VA== From: Sasha Levin To: stable@vger.kernel.org Cc: Mathieu Dubois-Briand , Andy Shevchenko , Bartosz Golaszewski , Lee Jones , Sasha Levin Subject: [PATCH 6.17.y 1/3] gpio: regmap: Allow to allocate regmap-irq device Date: Sun, 26 Oct 2025 12:25:26 -0400 Message-ID: <20251026162528.110183-1-sashal@kernel.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <2025102610-dissuade-tamer-7d92@gregkh> References: <2025102610-dissuade-tamer-7d92@gregkh> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Mathieu Dubois-Briand [ Upstream commit 553b75d4bfe9264f631d459fe9996744e0672b0e ] GPIO controller often have support for IRQ: allow to easily allocate both gpio-regmap and regmap-irq in one operation. Reviewed-by: Andy Shevchenko Acked-by: Bartosz Golaszewski Signed-off-by: Mathieu Dubois-Briand Link: https://lore.kernel.org/r/20250824-mdb-max7360-support-v14-5-435cfda2b1ea@bootlin.com Signed-off-by: Lee Jones Stable-dep-of: 2ba5772e530f ("gpio: idio-16: Define fixed direction of the GPIO lines") Signed-off-by: Sasha Levin --- drivers/gpio/gpio-regmap.c | 29 +++++++++++++++++++++++++++-- include/linux/gpio/regmap.h | 11 +++++++++++ 2 files changed, 38 insertions(+), 2 deletions(-) diff --git a/drivers/gpio/gpio-regmap.c b/drivers/gpio/gpio-regmap.c index 3f8b72311f8e8..7633c24ba27cd 100644 --- a/drivers/gpio/gpio-regmap.c +++ b/drivers/gpio/gpio-regmap.c @@ -32,6 +32,11 @@ struct gpio_regmap { unsigned int reg_dir_in_base; unsigned int reg_dir_out_base; +#ifdef CONFIG_REGMAP_IRQ + int regmap_irq_line; + struct regmap_irq_chip_data *irq_chip_data; +#endif + int (*reg_mask_xlate)(struct gpio_regmap *gpio, unsigned int base, unsigned int offset, unsigned int *reg, unsigned int *mask); @@ -215,6 +220,7 @@ EXPORT_SYMBOL_GPL(gpio_regmap_get_drvdata); */ struct gpio_regmap *gpio_regmap_register(const struct gpio_regmap_config *config) { + struct irq_domain *irq_domain; struct gpio_regmap *gpio; struct gpio_chip *chip; int ret; @@ -295,8 +301,22 @@ struct gpio_regmap *gpio_regmap_register(const struct gpio_regmap_config *config if (ret < 0) goto err_free_gpio; - if (config->irq_domain) { - ret = gpiochip_irqchip_add_domain(chip, config->irq_domain); +#ifdef CONFIG_REGMAP_IRQ + if (config->regmap_irq_chip) { + gpio->regmap_irq_line = config->regmap_irq_line; + ret = regmap_add_irq_chip_fwnode(dev_fwnode(config->parent), config->regmap, + config->regmap_irq_line, config->regmap_irq_flags, + 0, config->regmap_irq_chip, &gpio->irq_chip_data); + if (ret) + goto err_free_gpio; + + irq_domain = regmap_irq_get_domain(gpio->irq_chip_data); + } else +#endif + irq_domain = config->irq_domain; + + if (irq_domain) { + ret = gpiochip_irqchip_add_domain(chip, irq_domain); if (ret) goto err_remove_gpiochip; } @@ -317,6 +337,11 @@ EXPORT_SYMBOL_GPL(gpio_regmap_register); */ void gpio_regmap_unregister(struct gpio_regmap *gpio) { +#ifdef CONFIG_REGMAP_IRQ + if (gpio->irq_chip_data) + regmap_del_irq_chip(gpio->regmap_irq_line, gpio->irq_chip_data); +#endif + gpiochip_remove(&gpio->gpio_chip); kfree(gpio); } diff --git a/include/linux/gpio/regmap.h b/include/linux/gpio/regmap.h index c722c67668c6e..19b52ac03a5de 100644 --- a/include/linux/gpio/regmap.h +++ b/include/linux/gpio/regmap.h @@ -40,6 +40,11 @@ struct regmap; * @drvdata: (Optional) Pointer to driver specific data which is * not used by gpio-remap but is provided "as is" to the * driver callback(s). + * @regmap_irq_chip: (Optional) Pointer on an regmap_irq_chip structure. If + * set, a regmap-irq device will be created and the IRQ + * domain will be set accordingly. + * @regmap_irq_line (Optional) The IRQ the device uses to signal interrupts. + * @regmap_irq_flags (Optional) The IRQF_ flags to use for the interrupt. * * The ->reg_mask_xlate translates a given base address and GPIO offset to * register and mask pair. The base address is one of the given register @@ -78,6 +83,12 @@ struct gpio_regmap_config { int ngpio_per_reg; struct irq_domain *irq_domain; +#ifdef CONFIG_REGMAP_IRQ + struct regmap_irq_chip *regmap_irq_chip; + int regmap_irq_line; + unsigned long regmap_irq_flags; +#endif + int (*reg_mask_xlate)(struct gpio_regmap *gpio, unsigned int base, unsigned int offset, unsigned int *reg, unsigned int *mask); -- 2.51.0