From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B5CAE31B82E for ; Mon, 27 Oct 2025 18:42:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761590571; cv=none; b=iXtecZigQug73QVlNHYVAxSm+a0QnnPdP7SdqGo6+aRBND7JDvfZXG1fK6iTU7tJQSvMF5gUpGCVM0L1bDTgXbFDG877R6mKCVpQTPfsxQGccp5wRHTh+lOZRlz7m/eu2nHQodrT7iLfVajXmRpT6BWD4znNNQzyapGHNozwW+I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761590571; c=relaxed/simple; bh=Ckwe6bHp0CdVI6m0xvtOxnT6bprh/v1lMkEQpLjYPug=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=IaCzhcwLTfTQ4AXDI2iHc4pK1UqXOcMhrq5RrOsNsR6OiLSxKLqaeSz7cG4+lrpyjsUo7BF8bICqEqVOoEd7J7Y0gsP7ruYu6xyB4e9Tzhwx/6X3AyiXQPCJ6WO0tgM1SIaHRg3XjXeT2xWp+zv02v7/tH0ERJCav9wbg/V78rc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ug9nwPG/; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ug9nwPG/" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 18C1AC116B1; Mon, 27 Oct 2025 18:42:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1761590571; bh=Ckwe6bHp0CdVI6m0xvtOxnT6bprh/v1lMkEQpLjYPug=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ug9nwPG/ZWA1fiQ5XEXZ/Nnfvbtr3YHGq6tqEZvldR+OS6jzkFTSaG0Zgr3Hlo1oc g1gMnM39SgPc6L8gRAqII+Mzf1tAEj7nwsrNrfmeRA+T7++vDrQwhXNR1kTMlYM9i+ sn5hpvQARwG2wvqvq3qpIJLuEiWHX9XfAX7FBuo3wr34jf2IvNu0Zr/6NKxPXoIHB3 fh35nqnFyy0aie/jvU4x+XczqhXB18VXCYYBALX74vOUZ4Nw3cBecv86Gd/YkONLoo btaFS6N42vtXC3fVpTWlY10udotuKyvHxFlZKmJJRxxHUn/mmDudiKbmYqz3jdrTDl BNex6x7aBNMYg== From: Sasha Levin To: stable@vger.kernel.org Cc: Andy Shevchenko , Greg Kroah-Hartman , Sasha Levin Subject: [PATCH 5.10.y 1/2] serial: 8250_dw: Use devm_add_action_or_reset() Date: Mon, 27 Oct 2025 14:42:48 -0400 Message-ID: <20251027184249.638796-1-sashal@kernel.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <2025102700-sleep-robotics-c9e3@gregkh> References: <2025102700-sleep-robotics-c9e3@gregkh> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Andy Shevchenko [ Upstream commit 295b09128d12fb1a7a67f771cc0ae0df869eafaf ] Slightly simplify ->probe() and drop a few goto labels by using devm_add_action_or_reset() for clock and reset cleanup. Signed-off-by: Andy Shevchenko Link: https://lore.kernel.org/r/20220509172129.37770-1-andriy.shevchenko@linux.intel.com Signed-off-by: Greg Kroah-Hartman Stable-dep-of: daeb4037adf7 ("serial: 8250_dw: handle reset control deassert error") Signed-off-by: Sasha Levin --- drivers/tty/serial/8250/8250_dw.c | 63 +++++++++++++++---------------- 1 file changed, 31 insertions(+), 32 deletions(-) diff --git a/drivers/tty/serial/8250/8250_dw.c b/drivers/tty/serial/8250/8250_dw.c index ace221afeb039..6abdebb63ecbe 100644 --- a/drivers/tty/serial/8250/8250_dw.c +++ b/drivers/tty/serial/8250/8250_dw.c @@ -438,6 +438,16 @@ static void dw8250_quirks(struct uart_port *p, struct dw8250_data *data) } } +static void dw8250_clk_disable_unprepare(void *data) +{ + clk_disable_unprepare(data); +} + +static void dw8250_reset_control_assert(void *data) +{ + reset_control_assert(data); +} + static int dw8250_probe(struct platform_device *pdev) { struct uart_8250_port uart = {}, *up = &uart; @@ -539,35 +549,43 @@ static int dw8250_probe(struct platform_device *pdev) if (err) dev_warn(dev, "could not enable optional baudclk: %d\n", err); + err = devm_add_action_or_reset(dev, dw8250_clk_disable_unprepare, data->clk); + if (err) + return err; + if (data->clk) p->uartclk = clk_get_rate(data->clk); /* If no clock rate is defined, fail. */ if (!p->uartclk) { dev_err(dev, "clock rate not defined\n"); - err = -EINVAL; - goto err_clk; + return -EINVAL; } data->pclk = devm_clk_get_optional(dev, "apb_pclk"); - if (IS_ERR(data->pclk)) { - err = PTR_ERR(data->pclk); - goto err_clk; - } + if (IS_ERR(data->pclk)) + return PTR_ERR(data->pclk); err = clk_prepare_enable(data->pclk); if (err) { dev_err(dev, "could not enable apb_pclk\n"); - goto err_clk; + return err; } + err = devm_add_action_or_reset(dev, dw8250_clk_disable_unprepare, data->pclk); + if (err) + return err; + data->rst = devm_reset_control_get_optional_exclusive(dev, NULL); - if (IS_ERR(data->rst)) { - err = PTR_ERR(data->rst); - goto err_pclk; - } + if (IS_ERR(data->rst)) + return PTR_ERR(data->rst); + reset_control_deassert(data->rst); + err = devm_add_action_or_reset(dev, dw8250_reset_control_assert, data->rst); + if (err) + return err; + dw8250_quirks(p, data); /* If the Busy Functionality is not implemented, don't handle it */ @@ -585,10 +603,8 @@ static int dw8250_probe(struct platform_device *pdev) } data->data.line = serial8250_register_8250_port(up); - if (data->data.line < 0) { - err = data->data.line; - goto err_reset; - } + if (data->data.line < 0) + return data->data.line; /* * Some platforms may provide a reference clock shared between several @@ -609,17 +625,6 @@ static int dw8250_probe(struct platform_device *pdev) pm_runtime_enable(dev); return 0; - -err_reset: - reset_control_assert(data->rst); - -err_pclk: - clk_disable_unprepare(data->pclk); - -err_clk: - clk_disable_unprepare(data->clk); - - return err; } static int dw8250_remove(struct platform_device *pdev) @@ -637,12 +642,6 @@ static int dw8250_remove(struct platform_device *pdev) serial8250_unregister_port(data->data.line); - reset_control_assert(data->rst); - - clk_disable_unprepare(data->pclk); - - clk_disable_unprepare(data->clk); - pm_runtime_disable(dev); pm_runtime_put_noidle(dev); -- 2.51.0