From: Greg KH <greg@kroah.com>
To: Sasha Levin <sashal@kernel.org>
Cc: stable@vger.kernel.org, William Breathitt Gray <wbg@kernel.org>,
Mark Cave-Ayland <mark.caveayland@nutanix.com>,
Michael Walle <mwalle@kernel.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Subject: Re: [PATCH 6.12.y] gpio: idio-16: Define fixed direction of the GPIO lines
Date: Mon, 27 Oct 2025 09:02:30 +0100 [thread overview]
Message-ID: <2025102724-womb-width-695a@gregkh> (raw)
In-Reply-To: <20251026225104.272662-1-sashal@kernel.org>
On Sun, Oct 26, 2025 at 06:51:03PM -0400, Sasha Levin wrote:
> From: William Breathitt Gray <wbg@kernel.org>
>
> [ Upstream commit 2ba5772e530f73eb847fb96ce6c4017894869552 ]
>
> The direction of the IDIO-16 GPIO lines is fixed with the first 16 lines
> as output and the remaining 16 lines as input. Set the gpio_config
> fixed_direction_output member to represent the fixed direction of the
> GPIO lines.
>
> Fixes: db02247827ef ("gpio: idio-16: Migrate to the regmap API")
> Reported-by: Mark Cave-Ayland <mark.caveayland@nutanix.com>
> Closes: https://lore.kernel.org/r/9b0375fd-235f-4ee1-a7fa-daca296ef6bf@nutanix.com
> Suggested-by: Michael Walle <mwalle@kernel.org>
> Cc: stable@vger.kernel.org # ae495810cffe: gpio: regmap: add the .fixed_direction_output configuration parameter
> Cc: stable@vger.kernel.org
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Signed-off-by: William Breathitt Gray <wbg@kernel.org>
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
> Link: https://lore.kernel.org/r/20251020-fix-gpio-idio-16-regmap-v2-3-ebeb50e93c33@kernel.org
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> [ Adjust context ]
> Signed-off-by: Sasha Levin <sashal@kernel.org>
> ---
> drivers/gpio/gpio-idio-16.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/gpio/gpio-idio-16.c b/drivers/gpio/gpio-idio-16.c
> index 2c95125892972..f7e557c2c9cd4 100644
> --- a/drivers/gpio/gpio-idio-16.c
> +++ b/drivers/gpio/gpio-idio-16.c
> @@ -3,6 +3,7 @@
> * GPIO library for the ACCES IDIO-16 family
> * Copyright (C) 2022 William Breathitt Gray
> */
> +#include <linux/bitmap.h>
> #include <linux/bits.h>
> #include <linux/device.h>
> #include <linux/err.h>
> @@ -106,6 +107,7 @@ int devm_idio_16_regmap_register(struct device *const dev,
> struct idio_16_data *data;
> struct regmap_irq_chip *chip;
> struct regmap_irq_chip_data *chip_data;
> + DECLARE_BITMAP(fixed_direction_output, IDIO_16_NGPIO);
>
> if (!config->parent)
> return -EINVAL;
> @@ -163,6 +165,9 @@ int devm_idio_16_regmap_register(struct device *const dev,
> gpio_config.irq_domain = regmap_irq_get_domain(chip_data);
> gpio_config.reg_mask_xlate = idio_16_reg_mask_xlate;
>
> + bitmap_from_u64(fixed_direction_output, GENMASK_U64(15, 0));
> + gpio_config.fixed_direction_output = fixed_direction_output;
> +
> return PTR_ERR_OR_ZERO(devm_gpio_regmap_register(dev, &gpio_config));
> }
> EXPORT_SYMBOL_GPL(devm_idio_16_regmap_register);
> --
> 2.51.0
>
>
Breaks the build :(
next prev parent reply other threads:[~2025-10-27 8:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-26 14:23 FAILED: patch "[PATCH] gpio: idio-16: Define fixed direction of the GPIO lines" failed to apply to 6.12-stable tree gregkh
2025-10-26 22:51 ` [PATCH 6.12.y] gpio: idio-16: Define fixed direction of the GPIO lines Sasha Levin
2025-10-27 6:48 ` William Breathitt Gray
2025-10-27 8:02 ` Greg KH [this message]
2025-10-31 9:33 ` [PATCH 6.12.y 1/5] bits: add comments and newlines to #if, #else and #endif directives William Breathitt Gray
2025-10-31 9:33 ` [PATCH 6.12.y 2/5] bits: introduce fixed-type GENMASK_U*() William Breathitt Gray
2025-10-31 9:33 ` [PATCH 6.12.y 3/5] gpio: regmap: Allow to allocate regmap-irq device William Breathitt Gray
2025-10-31 9:33 ` [PATCH 6.12.y 4/5] gpio: regmap: add the .fixed_direction_output configuration parameter William Breathitt Gray
2025-10-31 9:33 ` [PATCH 6.12.y 5/5] gpio: idio-16: Define fixed direction of the GPIO lines William Breathitt Gray
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025102724-womb-width-695a@gregkh \
--to=greg@kroah.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bartosz.golaszewski@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=mark.caveayland@nutanix.com \
--cc=mwalle@kernel.org \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
--cc=wbg@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox