From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f180.google.com (mail-pg1-f180.google.com [209.85.215.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E609631B13F for ; Mon, 3 Nov 2025 16:48:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762188501; cv=none; b=GU3U2Sgmsb+ihwAbZovj10HA1g4N3OIao+9n1xy5XnY3NUcSnJz7zG2ifxAqfxujq4wiyAXCHS7j66YaqqfEQtHW9HQCLRDnhrlLAW8C0jWIYTixPW2e75xjPUKHDNcS0VXLyakotv5L7cw2HMFz8gZ6nQuRe/uID4mIyuykB18= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762188501; c=relaxed/simple; bh=nWCX9Xn/+IKfnehkSs57lbJDTkS9u5nAvInJtc9YeA4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=A3Hj0XrN+H61XVPKAwWSg99fuFLG5OCm3opWyDnWgq8MgszKA3PgV8B8kTcVPG1mAh2KQowXo4KgTFlV0fYyqPDtQJA7VAZWGxOa/TOtS5/6QoqHKenEPOIVGV4I1pNBrrOuPR89gDYNKCDzkU42Eka8Iom5BGZ9rX5NiXjWQrc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=XUJzfOx8; arc=none smtp.client-ip=209.85.215.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="XUJzfOx8" Received: by mail-pg1-f180.google.com with SMTP id 41be03b00d2f7-b5a631b9c82so2841510a12.1 for ; Mon, 03 Nov 2025 08:48:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1762188499; x=1762793299; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=+UbgPj8GVBWuehInulfgB6O/0NvS5woL/wIoY+Rh1do=; b=XUJzfOx8Rgk5EhTJsTuTJ8g4wGWIrb+B4Nmb45rywAwTzwQIrfocseKtTizDCxZTY6 OckdhFdR7IXuyxayuxEJ25i/58c8bzqNhk/cSlg4rEncYfw0MIAx2R9BnB4OPPzTl3nP jjGmwTPnFUe22OKF+KKyU8LUw2cNLQJygRO9/lb+o0O0nc0K4d1KINAD89hYqRqLAF0f TtoCH/Et525wmvJJaBOQ+Bi/vILYpTnV36pwd7Ptu0r/Joqx0015mIF3o5/qgf4foXhv 9BUURVdB+XGf6Tv/tz6XxgU+jjx58r7MyZtOVg8pYGBmsPEOccZXnSVjLey4Ba54xNdC LSfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1762188499; x=1762793299; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+UbgPj8GVBWuehInulfgB6O/0NvS5woL/wIoY+Rh1do=; b=tFREURXZD9vSwCz2G7CwoPr09Y5ARIMsS6FPAY89pBxfjz5zkkYA8biSaRUUzpWAYd ao5b4l9VKpvdERBkpT2KCY7kviPzKlBtAthJdUQPLvm30v5g+FlE/ioVvvM/M5Rw1SvE 8uxA4BKnLuVWQ/ic8YhsUSAoo1/zIi0jsR2aY4yNMiyfta6SfkKVsk21hGLfdSnwZ4RJ 23IzIzMQNOJCpGzFDaMx7pxMEwSy/4qudvUoB5I9MjS45wE6WgiJIq7X6/JbHtkbvnCr s6aIDFdzhkf+6JsrvsSkn+GqyxdAGY+fFnVl6Of/biJJSoMrpIagXDCewrpvUIGbvev6 Xrsw== X-Forwarded-Encrypted: i=1; AJvYcCUWmH5Xa2FcZwxDRRgLJ/QTuB/v7TSL8rYKPtl/lLoMe9QtDXzBO/D2TYlDT+bs8tPcRdUO1pk=@vger.kernel.org X-Gm-Message-State: AOJu0YybXSqdD7qy5NOcW6rfw7crL7RRNo8Mjz5F+E25SxDytqpVK41j OpJAyRo1r8BYW5ZofefKUdI11wfg+L8wndqeXerOuVdBD1WudPemuSNU X-Gm-Gg: ASbGncvNqAcJ0+0K3UKbXgkcrtAeQo2vVtINcQgeUFRwGp7rAaNUT+FPOq8YVCqfBfA dkGB6JF51uPHqcrIv6B5JcFQ3IRXh5JitIEs67Q9qZ88ayvpNN4f+quib9WnzBtXEJvrLGknvxM A4t0RCArK2qOBvdaeIrcEXvFwoUfYqroVE6Y+Xwqdbslrc2/cHeH/k7ZwdbmIZnE0wzI/wjji7N +yX8jtWxvxy6taUimb3mR8ROmgrbQkV4wpm+fOxwruf14gNhDBLd0f8lJqIUFtGtFjcesY90+uX rxIwawCw9Oe3JC7y5xL+w+vYx2ebsvJ6Pj2ksnZPpU8jtYFqXHfRszQztK/SBwaG0qAPMi/s8+b LatqFUqhpKTzMMPdcjb8Vgzun+QJfn9WdWfqO1pggh3TJZH98eDlXEuBvJN/BArKm21zxCSXOJd KEU2TOkfEUg3r+DKMgNRYz X-Google-Smtp-Source: AGHT+IEyuTHSlueto2QQ6kf1+GNae44GAu5fq+5W3NoVv8SuS2FAXtOnrUjUNMsA9RRKaWGorvWX3A== X-Received: by 2002:a17:903:4b04:b0:295:4d76:95fa with SMTP id d9443c01a7336-2954d7698c5mr99114655ad.60.1762188499151; Mon, 03 Nov 2025 08:48:19 -0800 (PST) Received: from monty-pavel.. ([2409:8a00:79b4:1a90:e46b:b524:f579:242b]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-34159a15b6fsm1607264a91.18.2025.11.03.08.48.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Nov 2025 08:48:18 -0800 (PST) From: Yongpeng Yang To: Namjae Jeon , Sungjong Seo , OGAWA Hirofumi , Jan Kara , Carlos Maiolino , Jens Axboe , Greg Kroah-Hartman , Sasha Levin , Alexander Viro , Christian Brauner , Christoph Hellwig Cc: linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, stable@vger.kernel.org, Matthew Wilcox , "Darrick J . Wong" , Yongpeng Yang Subject: [PATCH v5 3/5] isofs: check the return value of sb_min_blocksize() in isofs_fill_super Date: Tue, 4 Nov 2025 00:47:21 +0800 Message-ID: <20251103164722.151563-4-yangyongpeng.storage@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251103164722.151563-2-yangyongpeng.storage@gmail.com> References: <20251103164722.151563-2-yangyongpeng.storage@gmail.com> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Yongpeng Yang sb_min_blocksize() may return 0. Check its return value to avoid opt->blocksize and sb->s_blocksize is 0. Cc: # v6.15 Fixes: 1b17a46c9243e9 ("isofs: convert isofs to use the new mount API") Reviewed-by: Jan Kara Signed-off-by: Yongpeng Yang --- fs/isofs/inode.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/fs/isofs/inode.c b/fs/isofs/inode.c index 6f0e6b19383c..ad3143d4066b 100644 --- a/fs/isofs/inode.c +++ b/fs/isofs/inode.c @@ -610,6 +610,11 @@ static int isofs_fill_super(struct super_block *s, struct fs_context *fc) goto out_freesbi; } opt->blocksize = sb_min_blocksize(s, opt->blocksize); + if (!opt->blocksize) { + printk(KERN_ERR + "ISOFS: unable to set blocksize\n"); + goto out_freesbi; + } sbi->s_high_sierra = 0; /* default is iso9660 */ sbi->s_session = opt->session; -- 2.43.0