From: Greg KH <gregkh@linuxfoundation.org>
To: "Matthieu Baerts (NGI0)" <matttbe@kernel.org>
Cc: stable@vger.kernel.org, sashal@kernel.org,
MPTCP Upstream <mptcp@lists.linux.dev>
Subject: Re: [PATCH 6.12.y-5.10.y] selftests: mptcp: connect modes: re-add exec mode
Date: Tue, 4 Nov 2025 08:54:01 +0900 [thread overview]
Message-ID: <2025110410-cake-tasty-1a16@gregkh> (raw)
In-Reply-To: <20251103165433.6396-2-matttbe@kernel.org>
On Mon, Nov 03, 2025 at 05:54:34PM +0100, Matthieu Baerts (NGI0) wrote:
> It looks like the execution permissions (+x) got lost during the
> backports of these new files.
>
> The issue is that some CIs don't execute these tests without that.
>
> Fixes: 37848a456fc3 ("selftests: mptcp: connect: also cover alt modes")
> Fixes: fdf0f60a2bb0 ("selftests: mptcp: connect: also cover checksum")
> Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
> ---
> I'm not sure why they got lost, maybe Quilt doesn't support that? But
> then, can this patch still be applied?
> The same patch can be applied up to v5.10. In v5.10, only
> mptcp_connect_mmap.sh file is present, but I can send a dedicated patch
> for v5.10.
> ---
> tools/testing/selftests/net/mptcp/mptcp_connect_checksum.sh | 0
> tools/testing/selftests/net/mptcp/mptcp_connect_mmap.sh | 0
> tools/testing/selftests/net/mptcp/mptcp_connect_sendfile.sh | 0
> 3 files changed, 0 insertions(+), 0 deletions(-)
> mode change 100644 => 100755 tools/testing/selftests/net/mptcp/mptcp_connect_checksum.sh
> mode change 100644 => 100755 tools/testing/selftests/net/mptcp/mptcp_connect_mmap.sh
> mode change 100644 => 100755 tools/testing/selftests/net/mptcp/mptcp_connect_sendfile.sh
>
> diff --git a/tools/testing/selftests/net/mptcp/mptcp_connect_checksum.sh b/tools/testing/selftests/net/mptcp/mptcp_connect_checksum.sh
> old mode 100644
> new mode 100755
> diff --git a/tools/testing/selftests/net/mptcp/mptcp_connect_mmap.sh b/tools/testing/selftests/net/mptcp/mptcp_connect_mmap.sh
> old mode 100644
> new mode 100755
> diff --git a/tools/testing/selftests/net/mptcp/mptcp_connect_sendfile.sh b/tools/testing/selftests/net/mptcp/mptcp_connect_sendfile.sh
> old mode 100644
> new mode 100755
> --
> 2.51.0
>
>
This is going to be a pain to apply, given that we use quilt, and that
does not handle modes well, if at all.
So yes, that is why these files are not marked executable, but I thought
we were moving away from that anyway, most scripts should not be marked
that way.
thanks,
greg k-h
next prev parent reply other threads:[~2025-11-03 23:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-03 16:54 [PATCH 6.12.y-5.10.y] selftests: mptcp: connect modes: re-add exec mode Matthieu Baerts (NGI0)
2025-11-03 23:54 ` Greg KH [this message]
2025-11-04 11:57 ` Matthieu Baerts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025110410-cake-tasty-1a16@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=matttbe@kernel.org \
--cc=mptcp@lists.linux.dev \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox