From: Lee Jones <lee@kernel.org>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: make24@iscas.ac.cn, mdf@kernel.org, stable@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Johan Hovold <johan@kernel.org>, Mark Brown <broonie@kernel.org>,
Suzuki Poulouse <suzuki.poulose@arm.com>,
Wolfram Sang <wsa@kernel.org>
Subject: Re: [PATCH] drivers: Fix reference leak in altr_sysmgr_regmap_lookup_by_phandle()
Date: Thu, 6 Nov 2025 14:39:09 +0000 [thread overview]
Message-ID: <20251106143909.GR8064@google.com> (raw)
In-Reply-To: <62ab3119-94d8-4d74-abb3-e141c4b85934@web.de>
On Sat, 25 Oct 2025, Markus Elfring wrote:
> …
> > Found by code review.
>
> See also the commit facd37d3882baad4a38afdd5f33908f6fc145d13
> ("mfd: altera-sysmgr: Fix device leak on sysmgr regmap lookup") from 2025-10-21.
This patch has the correct formatting and doesn't do extra, unnecessary
actions like store the regmap into a local variable for some unexplained
reason. For those reasons, I'm planning on taking this one instead.
--
Lee Jones [李琼斯]
prev parent reply other threads:[~2025-11-06 14:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-25 14:23 [PATCH] drivers: Fix reference leak in altr_sysmgr_regmap_lookup_by_phandle() Ma Ke
2025-10-25 20:13 ` Markus Elfring
2025-11-06 14:39 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251106143909.GR8064@google.com \
--to=lee@kernel.org \
--cc=Markus.Elfring@web.de \
--cc=akpm@linux-foundation.org \
--cc=broonie@kernel.org \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=make24@iscas.ac.cn \
--cc=mdf@kernel.org \
--cc=stable@vger.kernel.org \
--cc=suzuki.poulose@arm.com \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).