Linux kernel -stable discussions
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Peter Korsgaard <peter@korsgaard.com>
Cc: Ivan Vera <ivanverasantos@gmail.com>,
	git@amd.com, stable@vger.kernel.org,
	Michal Simek <michal.simek@amd.com>,
	Srinivas Kandagatla <srini@kernel.org>,
	Ivan Vera <ivan.vera@enclustra.com>
Subject: Re: [PATCH v6.6-LTS] nvmem: zynqmp_nvmem: unbreak driver after cleanup
Date: Thu, 6 Nov 2025 17:51:47 +0900	[thread overview]
Message-ID: <2025110624-huskiness-viewless-50fd@gregkh> (raw)
In-Reply-To: <87frar7gqz.fsf@dell.be.48ers.dk>

On Thu, Nov 06, 2025 at 08:38:28AM +0100, Peter Korsgaard wrote:
> >>>>> "Greg" == Greg KH <gregkh@linuxfoundation.org> writes:
> 
>  > On Wed, Nov 05, 2025 at 01:36:19PM +0100, Ivan Vera wrote:
>  >> From: Peter Korsgaard <peter@korsgaard.com>
>  >> 
>  >> Commit 29be47fcd6a0 ("nvmem: zynqmp_nvmem: zynqmp_nvmem_probe cleanup")
>  >> changed the driver to expect the device pointer to be passed as the
>  >> "context", but in nvmem the context parameter comes from nvmem_config.priv
>  >> which is never set - Leading to null pointer exceptions when the device is
>  >> accessed.
>  >> 
>  >> Fixes: 29be47fcd6a0 ("nvmem: zynqmp_nvmem: zynqmp_nvmem_probe cleanup")
>  >> Cc: stable@vger.kernel.org
>  >> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
>  >> Reviewed-by: Michal Simek <michal.simek@amd.com>
>  >> Tested-by: Michal Simek <michal.simek@amd.com>
>  >> Signed-off-by: Srinivas Kandagatla <srini@kernel.org>
>  >> State: upstream (c708bbd57d158d9f20c2fcea5bcb6e0afac77bef)
>  >> (cherry picked from commit 94c91acb3721403501bafcdd041bcd422c5b23c4)
> 
>  > Neither of these git ids are valid, where did you get them from?
> 
> git describe --contains c708bbd57d158d9f20c2fcea5bcb6e0afac77bef
> next-20250505~21^2~1^2
> 
> I guess it should have been fe8abdd175d7b547ae1a612757e7902bcd62e9cf
> instead, E.G. what ended up in master?

We can't take stuff in stable unless it is in Linus's tree.

thanks,

greg k-h

  reply	other threads:[~2025-11-06  8:51 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-05 12:36 [PATCH v6.6-LTS] nvmem: zynqmp_nvmem: unbreak driver after cleanup Ivan Vera
2025-11-06  7:23 ` Greg KH
2025-11-06  7:38   ` Peter Korsgaard
2025-11-06  8:51     ` Greg KH [this message]
2025-11-06  9:08       ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2025110624-huskiness-viewless-50fd@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=git@amd.com \
    --cc=ivan.vera@enclustra.com \
    --cc=ivanverasantos@gmail.com \
    --cc=michal.simek@amd.com \
    --cc=peter@korsgaard.com \
    --cc=srini@kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox