From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9E7772AE8D; Tue, 11 Nov 2025 00:49:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762822143; cv=none; b=QG1geD8pSmrs2av8hbwrR5zI/XILsdvEB/sVr+lqegv5Nr2zBnZH6TIy/jy8ach+6xQLaWoE6aviKTYLdVJh+w7bDiKnpcC0qPjaNUNcTVPla2jSogv3Ti/VKbrVn154n89s/qBl+mwYNBM8mZFpBoXALbo9QhnCOdOKj+Vtuew= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762822143; c=relaxed/simple; bh=7eZEshxuSl8J/hBQfknW38qlF+JiMzxRyqbepFbMZqE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=kVOviUgoYVyhHxG9gwvWBY9HIg0WVIzxjqxJOPOJLuK0QdyYH8ndhNOdLLZWNZPuzyWSzchC8LJrezOIgm615CvyhSp0R05PjRtj1gKbOGF1bN3mrtyef/3ihlVQeM4u1OeNIfU20FWkiJ6miws3VKF0n/5vyb8moaigSqYLlDs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=oD1knN5E; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="oD1knN5E" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3F73BC4CEF5; Tue, 11 Nov 2025 00:49:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1762822143; bh=7eZEshxuSl8J/hBQfknW38qlF+JiMzxRyqbepFbMZqE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=oD1knN5EsIOCwdpVfGxzN/iUeZYszUQQHKqmG9xVEfr0Ykkfx7E+O6pkn7RAOT4W0 laNrEfe1F2HkamHgLvZFbVyz2uVKrRl7vY//9n1IlpgBBTSURStuW3oaYYGau5Sueq HQFEqqHL2zKbRkZ9ey4MhE5Xy0vNQNXlRU5l7GC0= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Armin Wolf , "Rafael J. Wysocki" Subject: [PATCH 6.17 011/849] ACPI: fan: Use platform device for devres-related actions Date: Tue, 11 Nov 2025 09:33:01 +0900 Message-ID: <20251111004536.735029703@linuxfoundation.org> X-Mailer: git-send-email 2.51.2 In-Reply-To: <20251111004536.460310036@linuxfoundation.org> References: <20251111004536.460310036@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.17-stable review patch. If anyone has any objections, please let me know. ------------------ From: Armin Wolf commit d91a1d129b63614fa4c2e45e60918409ce36db7e upstream. Device-managed resources are cleaned up when the driver unbinds from the underlying device. In our case this is the platform device as this driver is a platform driver. Registering device-managed resources on the associated ACPI device will thus result in a resource leak when this driver unbinds. Ensure that any device-managed resources are only registered on the platform device to ensure that they are cleaned up during removal. Fixes: 35c50d853adc ("ACPI: fan: Add hwmon support") Signed-off-by: Armin Wolf Cc: 6.11+ # 6.11+ Link: https://patch.msgid.link/20251007234149.2769-4-W_Armin@gmx.de Signed-off-by: Rafael J. Wysocki Signed-off-by: Greg Kroah-Hartman --- drivers/acpi/fan.h | 4 ++-- drivers/acpi/fan_core.c | 2 +- drivers/acpi/fan_hwmon.c | 8 ++++---- 3 files changed, 7 insertions(+), 7 deletions(-) --- a/drivers/acpi/fan.h +++ b/drivers/acpi/fan.h @@ -64,9 +64,9 @@ int acpi_fan_create_attributes(struct ac void acpi_fan_delete_attributes(struct acpi_device *device); #if IS_REACHABLE(CONFIG_HWMON) -int devm_acpi_fan_create_hwmon(struct acpi_device *device); +int devm_acpi_fan_create_hwmon(struct device *dev); #else -static inline int devm_acpi_fan_create_hwmon(struct acpi_device *device) { return 0; }; +static inline int devm_acpi_fan_create_hwmon(struct device *dev) { return 0; }; #endif #endif --- a/drivers/acpi/fan_core.c +++ b/drivers/acpi/fan_core.c @@ -347,7 +347,7 @@ static int acpi_fan_probe(struct platfor } if (fan->has_fst) { - result = devm_acpi_fan_create_hwmon(device); + result = devm_acpi_fan_create_hwmon(&pdev->dev); if (result) return result; --- a/drivers/acpi/fan_hwmon.c +++ b/drivers/acpi/fan_hwmon.c @@ -167,12 +167,12 @@ static const struct hwmon_chip_info acpi .info = acpi_fan_hwmon_info, }; -int devm_acpi_fan_create_hwmon(struct acpi_device *device) +int devm_acpi_fan_create_hwmon(struct device *dev) { - struct acpi_fan *fan = acpi_driver_data(device); + struct acpi_fan *fan = dev_get_drvdata(dev); struct device *hdev; - hdev = devm_hwmon_device_register_with_info(&device->dev, "acpi_fan", fan, - &acpi_fan_hwmon_chip_info, NULL); + hdev = devm_hwmon_device_register_with_info(dev, "acpi_fan", fan, &acpi_fan_hwmon_chip_info, + NULL); return PTR_ERR_OR_ZERO(hdev); }