From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Oleksij Rempel <o.rempel@pengutronix.de>
Cc: "A. Sverdlin" <alexander.sverdlin@siemens.com>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
linux-iio@vger.kernel.org, Ahmad Fatoum <a.fatoum@pengutronix.de>,
"Paul E . McKenney" <paulmck@kernel.org>,
linux-kernel@vger.kernel.org, stable@vger.kernel.org,
Jonathan Cameron <Jonathan.Cameron@huawei.com>,
William Breathitt Gray <wbg@kernel.org>
Subject: Re: [PATCH] counter: interrupt-cnt: Drop IRQF_NO_THREAD flag
Date: Tue, 18 Nov 2025 11:08:42 +0100 [thread overview]
Message-ID: <20251118100842.jPZMHpnF@linutronix.de> (raw)
In-Reply-To: <aRw4mIZpWdsr9exb@pengutronix.de>
On 2025-11-18 10:12:56 [+0100], Oleksij Rempel wrote:
> Hi Alexander,
Hi,
> > --- a/drivers/counter/interrupt-cnt.c
> > +++ b/drivers/counter/interrupt-cnt.c
> > @@ -229,8 +229,7 @@ static int interrupt_cnt_probe(struct platform_device *pdev)
> >
> > irq_set_status_flags(priv->irq, IRQ_NOAUTOEN);
> > ret = devm_request_irq(dev, priv->irq, interrupt_cnt_isr,
> > - IRQF_TRIGGER_RISING | IRQF_NO_THREAD,
> > - dev_name(dev), counter);
> > + IRQF_TRIGGER_RISING, dev_name(dev), counter);
> > if (ret)
> > return ret;
> >
>
> Hm, I guess it will break the requirement to handle at least 10kHz
> interrupts. May be we should move only counter_push_event() to the
> thread? or using delayed worker?
IRQF_NO_THREAD only prohibits threading of interrupts on !RT if
threadirqs was specified on the boot command line. This should not
effect you general use case.
As the threaded interrupt runs as SCHED_FIFO-50 it will be preferred
over any SCHED_OTHER so it still should the most prefer task in the
system. 10kHz interrupt sounds like one interrupt every 100us. This
sounds like a lot if the CPU is also doing other things.
Anyway.
> Right now I do not have needed system for testing to come with better
> proposal.
>
> Best Regards,
> Oleksij
Sebastian
next prev parent reply other threads:[~2025-11-18 10:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-18 8:35 [PATCH] counter: interrupt-cnt: Drop IRQF_NO_THREAD flag A. Sverdlin
2025-11-18 9:12 ` Oleksij Rempel
2025-11-18 9:51 ` Sverdlin, Alexander
2025-11-18 9:54 ` Oleksij Rempel
2025-11-18 10:08 ` Sebastian Andrzej Siewior [this message]
2025-11-18 10:30 ` Sebastian Andrzej Siewior
2025-11-30 13:57 ` William Breathitt Gray
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251118100842.jPZMHpnF@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=Jonathan.Cameron@huawei.com \
--cc=a.fatoum@pengutronix.de \
--cc=alexander.sverdlin@siemens.com \
--cc=kernel@pengutronix.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=paulmck@kernel.org \
--cc=stable@vger.kernel.org \
--cc=wbg@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox