From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4FBF6190477; Fri, 21 Nov 2025 13:29:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763731783; cv=none; b=RZGO0shwRo/3dJimtcbPWIAR1+lnOKonb+pxs3dQSCpHpm89BCWhZNy+4LSUYbhR/34SSPf2qMxbM9ixiKyaKP0mem7pedo5m8FSYhLglnpMSWz0X93xXnxxz0sLIR9ui6+39jgwrm0N+SZcFfUtZScaar4CS84MLFrZ9AUrvh4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763731783; c=relaxed/simple; bh=SV+dCIIMyTZNbrnDWO6q3b+TNK321+MX3S0Exrdd84c=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=kxCj9CIrUGINVE8dyWMLt7dbjQLKpG3u52WpeVO5wlRr7qGk2Jl+mhNHLyCA7FLe5buWub/DQ3zuHexUcckGEzPuqQNylRdVIS0DYd3fAVFLk3WkvZQMRAnyBOSbv48E/+f1O6A/vVeCFsk5HKZ4V46FoWtPOze0H7e9Poy/uf8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=shmdIfi2; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="shmdIfi2" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D1B1FC4CEF1; Fri, 21 Nov 2025 13:29:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1763731783; bh=SV+dCIIMyTZNbrnDWO6q3b+TNK321+MX3S0Exrdd84c=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=shmdIfi2BN6mo1at4vqSV/vJzyEbo88+pGBa3WPqxTUIv4FBRTygYVtRQwXFy1vYJ rN7FsDSpqcntGHY1vddb/9wps5G2Fgn+tmDfXtTjQPNE6Ulyh6kXKca33BGx6VDH1B 1wUQkx/oElfNn/+8louk4QsNvL6Naq2XS5GbdJ3Y= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Dan Carpenter , Harshit Mogalapalli , Trond Myklebust , Anna Schumaker , Sasha Levin Subject: [PATCH 6.12 078/185] NFSv4: Fix an incorrect parameter when calling nfs4_call_sync() Date: Fri, 21 Nov 2025 14:11:45 +0100 Message-ID: <20251121130146.686064069@linuxfoundation.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251121130143.857798067@linuxfoundation.org> References: <20251121130143.857798067@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.12-stable review patch. If anyone has any objections, please let me know. ------------------ From: Trond Myklebust [ Upstream commit 1f214e9c3aef2d0936be971072e991d78a174d71 ] The Smatch static checker noted that in _nfs4_proc_lookupp(), the flag RPC_TASK_TIMEOUT is being passed as an argument to nfs4_init_sequence(), which is clearly incorrect. Since LOOKUPP is an idempotent operation, nfs4_init_sequence() should not ask the server to cache the result. The RPC_TASK_TIMEOUT flag needs to be passed down to the RPC layer. Reported-by: Dan Carpenter Reported-by: Harshit Mogalapalli Fixes: 76998ebb9158 ("NFSv4: Observe the NFS_MOUNT_SOFTREVAL flag in _nfs4_proc_lookupp") Signed-off-by: Trond Myklebust Signed-off-by: Anna Schumaker Signed-off-by: Sasha Levin --- fs/nfs/nfs4proc.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c index a4531386c6485..6342d360732d2 100644 --- a/fs/nfs/nfs4proc.c +++ b/fs/nfs/nfs4proc.c @@ -4695,16 +4695,19 @@ static int _nfs4_proc_lookupp(struct inode *inode, }; unsigned short task_flags = 0; - if (NFS_SERVER(inode)->flags & NFS_MOUNT_SOFTREVAL) + if (server->flags & NFS_MOUNT_SOFTREVAL) task_flags |= RPC_TASK_TIMEOUT; + if (server->caps & NFS_CAP_MOVEABLE) + task_flags |= RPC_TASK_MOVEABLE; args.bitmask = nfs4_bitmask(server, fattr->label); nfs_fattr_init(fattr); + nfs4_init_sequence(&args.seq_args, &res.seq_res, 0, 0); dprintk("NFS call lookupp ino=0x%lx\n", inode->i_ino); - status = nfs4_call_sync(clnt, server, &msg, &args.seq_args, - &res.seq_res, task_flags); + status = nfs4_do_call_sync(clnt, server, &msg, &args.seq_args, + &res.seq_res, task_flags); dprintk("NFS reply lookupp: %d\n", status); return status; } -- 2.51.0