From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C8FDB21E098; Fri, 21 Nov 2025 13:33:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763731997; cv=none; b=lEMh5GcZ81Hn6xaOumV42z/zgxfoG4S5G00wYfPXvBGC2gkG1jeCBnG17slMdxZer3ZW9ZsR09jFu6cNG+Ap9KdXf+YWqGdTNmriOvgD9Vq/JEbzhMZwqnxPTM1NUvqlI3QhuJqSE8olsYeqZ871AekknjpBzMeqLgCC+oPRc5M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763731997; c=relaxed/simple; bh=WODrmMq3HhMKxT8d+zl8LqyFfeH/2WF3AZCN+PvrO8c=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Pi+NAgenNkh3Bl6xDZinCG+xPsFzCHHAyYazoUgoIh9Rf+N9q4wPTYlYRTP6FV4JrmAtwBAM9mJOll6/TgOMKCu0FXNpVrjqP+I2+FG5UFDuJIYV/bY8N0J1fnmEv3lP5tQ/LW3BXkB8kyVUE6gPCn5tqZd5JEFx3BltUrKTwzA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=vbq4/ZLl; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="vbq4/ZLl" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 135BFC4CEF1; Fri, 21 Nov 2025 13:33:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1763731996; bh=WODrmMq3HhMKxT8d+zl8LqyFfeH/2WF3AZCN+PvrO8c=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=vbq4/ZLl1QTWut+HGWhJ3BuHqnA+P+XjdbA5HgtaJFDHMgFu7E0MEidDIN6iMxcNR xm7UlVmOfRUvrv6R0NSpOlmnkgbcKpeUT5ez9CXBEqztPcZby+FiPRyLlvdnvXLbwX CU1Emk9anVgiZgpcpNX6s/KU6GTYZ3LEnX118bok= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Peter Griffin , Krzysztof Kozlowski , =?UTF-8?q?Andr=C3=A9=20Draszik?= , Marek Szyprowski , Ulf Hansson Subject: [PATCH 6.12 152/185] pmdomain: samsung: plug potential memleak during probe Date: Fri, 21 Nov 2025 14:12:59 +0100 Message-ID: <20251121130149.362695375@linuxfoundation.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251121130143.857798067@linuxfoundation.org> References: <20251121130143.857798067@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 6.12-stable review patch. If anyone has any objections, please let me know. ------------------ From: André Draszik commit 90c82941adf1986364e0f82c35cf59f2bf5f6a1d upstream. of_genpd_add_provider_simple() could fail, in which case this code leaks the domain name, pd->pd.name. Use devm_kstrdup_const() to plug this leak. As a side-effect, we can simplify existing error handling. Fixes: c09a3e6c97f0 ("soc: samsung: pm_domains: Convert to regular platform driver") Cc: stable@vger.kernel.org Reviewed-by: Peter Griffin Reviewed-by: Krzysztof Kozlowski Signed-off-by: André Draszik Tested-by: Marek Szyprowski Signed-off-by: Ulf Hansson Signed-off-by: Greg Kroah-Hartman --- drivers/pmdomain/samsung/exynos-pm-domains.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) --- a/drivers/pmdomain/samsung/exynos-pm-domains.c +++ b/drivers/pmdomain/samsung/exynos-pm-domains.c @@ -92,13 +92,14 @@ static const struct of_device_id exynos_ { }, }; -static const char *exynos_get_domain_name(struct device_node *node) +static const char *exynos_get_domain_name(struct device *dev, + struct device_node *node) { const char *name; if (of_property_read_string(node, "label", &name) < 0) name = kbasename(node->full_name); - return kstrdup_const(name, GFP_KERNEL); + return devm_kstrdup_const(dev, name, GFP_KERNEL); } static int exynos_pd_probe(struct platform_device *pdev) @@ -115,15 +116,13 @@ static int exynos_pd_probe(struct platfo if (!pd) return -ENOMEM; - pd->pd.name = exynos_get_domain_name(np); + pd->pd.name = exynos_get_domain_name(dev, np); if (!pd->pd.name) return -ENOMEM; pd->base = of_iomap(np, 0); - if (!pd->base) { - kfree_const(pd->pd.name); + if (!pd->base) return -ENODEV; - } pd->pd.power_off = exynos_pd_power_off; pd->pd.power_on = exynos_pd_power_on;