From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1A7E7339B3C; Fri, 21 Nov 2025 13:43:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763732610; cv=none; b=D0kDw8nthRh8WsdjJb6ioOwXOaCOycS+XC4epLvRnCHfDenD1YGOJWHNs/SwUjp3IvEqxr7BytgjLTtO4P55UEanIfyx2yudY+u5FrFhHRw7XwCRn9hHsG3i2VaBfeAOko9moD0z6X5NcRfAkrqPJlOo3UGkKCeCmRk1RbTOHW4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763732610; c=relaxed/simple; bh=UB48A6IVvLKvqsHantBgbTPKo/ef/FqfaT7WDRYahOM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=q8ARY1nV/lTEjbPYYlXlcdTtl/+/QtJtmIAOaynhfxQYeKvdH3xhmdUHU0L/1ZWNHtvFT3e4ljI8s5KJ3Qdt7SZH36sD6qL34/LnW9JS2ljfpdEys8ZtRlPKJFeZhl3PbSLVIOx5dJ/a6M5cuyTE5aRMk+Ruf9G3mcgh9Q6/xGw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=xE92pzM9; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="xE92pzM9" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 95E8AC4CEF1; Fri, 21 Nov 2025 13:43:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1763732610; bh=UB48A6IVvLKvqsHantBgbTPKo/ef/FqfaT7WDRYahOM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=xE92pzM9Yy0BJ9AznFctXi2xlom3mmCr53cwZA3ZXHkEB7xoP0A5dCUUhp4sn1phE oHvUo7DB4l147Ry+jHFUh3683XrUKbi6F3qnn1qR4xxCk6qUI8q+J/N565CDQNRVnR dp7wWMO0fNpXq+EQWdB4bzZMv68UAUrkgeYXj7WE= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Dmitry Baryshkov , Krzysztof Kozlowski , Sasha Levin Subject: [PATCH 6.6 182/529] drm/msm/dsi/phy: Toggle back buffer resync after preparing PLL Date: Fri, 21 Nov 2025 14:08:01 +0100 Message-ID: <20251121130237.492444221@linuxfoundation.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251121130230.985163914@linuxfoundation.org> References: <20251121130230.985163914@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.6-stable review patch. If anyone has any objections, please let me know. ------------------ From: Krzysztof Kozlowski [ Upstream commit b63f008f395ca5f6bc89123db97440bdc19981c4 ] According to Hardware Programming Guide for DSI PHY, the retime buffer resync should be done after PLL clock users (byte_clk and intf_byte_clk) are enabled. Downstream also does it as part of configuring the PLL. Driver was only turning off the resync FIFO buffer, but never bringing it on again. Reviewed-by: Dmitry Baryshkov Signed-off-by: Krzysztof Kozlowski Patchwork: https://patchwork.freedesktop.org/patch/657823/ Link: https://lore.kernel.org/r/20250610-b4-sm8750-display-v6-6-ee633e3ddbff@linaro.org Signed-off-by: Dmitry Baryshkov Signed-off-by: Sasha Levin --- drivers/gpu/drm/msm/dsi/phy/dsi_phy_7nm.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/msm/dsi/phy/dsi_phy_7nm.c b/drivers/gpu/drm/msm/dsi/phy/dsi_phy_7nm.c index f72ce6a3c456d..47ee2fd569db4 100644 --- a/drivers/gpu/drm/msm/dsi/phy/dsi_phy_7nm.c +++ b/drivers/gpu/drm/msm/dsi/phy/dsi_phy_7nm.c @@ -445,6 +445,10 @@ static int dsi_pll_7nm_vco_prepare(struct clk_hw *hw) if (pll_7nm->slave) dsi_pll_enable_global_clk(pll_7nm->slave); + writel(0x1, pll_7nm->phy->base + REG_DSI_7nm_PHY_CMN_RBUF_CTRL); + if (pll_7nm->slave) + writel(0x1, pll_7nm->slave->phy->base + REG_DSI_7nm_PHY_CMN_RBUF_CTRL); + error: return rc; } -- 2.51.0