From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C113533C526; Fri, 21 Nov 2025 13:49:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763732941; cv=none; b=M9N7O+LrpVm17bwsvcGn4a26rNQho9I4Ngg1lXpctYKCZg3M5KwG5YHZl0TBgJBDzas10JwIPEZhHhfqyQoPR62w/EQcdciM5Z+zFJMGPV+bFm31pUueGPD+Ie5aRaSFvHOJRyNuU6bgFPnQ4PPmAVIKV8qmhbw6ms6Ejwmow88= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763732941; c=relaxed/simple; bh=06PR4VVm7aD+uAsVRGxG2RF2TfC68FDTxs6zuHXI8CA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=KOaxxLfItrtTvHGVZumK5QFVC3ZpkutyW7M4wmHbPQNRikha/GgRE5grqhG6S7aaJLGZ+sqVWaCDPCa2AaQTKCM1GfM+eFXKoUiXYitHysSjWfL+ssNwQrFtXI7SmJnoKfLFPxlvjZLHS4BpbAbdGKR7Ded35qSTDgCV7RbT0Rs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=k3SUUEsE; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="k3SUUEsE" Received: by smtp.kernel.org (Postfix) with ESMTPSA id AA035C4CEF1; Fri, 21 Nov 2025 13:49:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1763732941; bh=06PR4VVm7aD+uAsVRGxG2RF2TfC68FDTxs6zuHXI8CA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=k3SUUEsEwrVAGlj3ma60eYdnv7BTXMRv4y61+5xmtWu9Q18sczewZY5Uj5/Whg7TD 8VK+i0zZOUfh9m0B1nexrpuq/IcwEQy/JcB6Q2O4mj34DQxph2N2u75RznashdH5yS gTbjDB24AaN2J54t5PnAsBc2jbuTfYsOnRHubx8A= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Fiona Ebner , Steve French , Sasha Levin Subject: [PATCH 6.6 296/529] smb: client: transport: avoid reconnects triggered by pending task work Date: Fri, 21 Nov 2025 14:09:55 +0100 Message-ID: <20251121130241.559000203@linuxfoundation.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251121130230.985163914@linuxfoundation.org> References: <20251121130230.985163914@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.6-stable review patch. If anyone has any objections, please let me know. ------------------ From: Fiona Ebner [ Upstream commit 00be6f26a2a7c671f1402d74c4d3c30a5844660a ] When io_uring is used in the same task as CIFS, there might be unnecessary reconnects, causing issues in user-space applications like QEMU with a log like: > CIFS: VFS: \\10.10.100.81 Error -512 sending data on socket to server Certain io_uring completions might be added to task_work with notify_method being TWA_SIGNAL and thus TIF_NOTIFY_SIGNAL is set for the task. In __smb_send_rqst(), signals are masked before calling smb_send_kvec(), but the masking does not apply to TIF_NOTIFY_SIGNAL. If sk_stream_wait_memory() is reached via sock_sendmsg() while TIF_NOTIFY_SIGNAL is set, signal_pending(current) will evaluate to true there, and -EINTR will be propagated all the way from sk_stream_wait_memory() to sock_sendmsg() in smb_send_kvec(). Afterwards, __smb_send_rqst() will see that not everything was written and reconnect. Signed-off-by: Fiona Ebner Signed-off-by: Steve French Signed-off-by: Sasha Levin --- fs/smb/client/transport.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/fs/smb/client/transport.c b/fs/smb/client/transport.c index 7b2560612bd6a..719b04202ed1c 100644 --- a/fs/smb/client/transport.c +++ b/fs/smb/client/transport.c @@ -22,6 +22,7 @@ #include #include #include +#include #include "cifspdu.h" #include "cifsglob.h" #include "cifsproto.h" @@ -211,9 +212,16 @@ smb_send_kvec(struct TCP_Server_Info *server, struct msghdr *smb_msg, * send a packet. In most cases if we fail to send * after the retries we will kill the socket and * reconnect which may clear the network problem. + * + * Even if regular signals are masked, EINTR might be + * propagated from sk_stream_wait_memory() to here when + * TIF_NOTIFY_SIGNAL is used for task work. For example, + * certain io_uring completions will use that. Treat + * having EINTR with pending task work the same as EAGAIN + * to avoid unnecessary reconnects. */ rc = sock_sendmsg(ssocket, smb_msg); - if (rc == -EAGAIN) { + if (rc == -EAGAIN || unlikely(rc == -EINTR && task_work_pending(current))) { retries++; if (retries >= 14 || (!server->noblocksnd && (retries > 2))) { -- 2.51.0