From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 05C472C0287 for ; Mon, 24 Nov 2025 17:38:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764005904; cv=none; b=jea00DYWi//1FEHjnbWOd0Q6Iqg+iFpktvvWNn3MurD+BteheKT2DeDAptUY8jJxJWW5voENFOtArO8TIc1qVL+iCLZAVh0wJBYU0+8cn0437x8yV7ud4r/MJQrJjdbRwJ6t7mGbift+jLG9EsumT7CYl6xvfKucRpfivzeyaZ4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764005904; c=relaxed/simple; bh=yVP2S0I2nQiZ4TmD9NJzUt7vaaMgrCxub/1xieTOqho=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=cc1xcY0gmWsSKdV7jEP5QeeNCsak1MG4ojPlw/WcBAXyxuaRXQtBZprKUiq87jpcNyKHRQNT2PBcNkHqE6pSIIPFQBhJpmgL+6jKpqU4tpwFIQ2wcAbDFFXzpPQtAP9vjcRxKwsQU3Oni+qag9DeOmUPY+0bb9+G6n9ayzEb07M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=mCmDw6xs; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="mCmDw6xs" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D1E1DC116C6; Mon, 24 Nov 2025 17:38:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1764005903; bh=yVP2S0I2nQiZ4TmD9NJzUt7vaaMgrCxub/1xieTOqho=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=mCmDw6xsDCwFP0pijvln4FCsWUMTGs4W9V+gT63Q7eUsEHwRs34YIk5Cwkv+0kA+q O//Z4ELe2oYUd6OODqxNzgEwe+yyCY3bIvlAtoi8YLtitfA6NCe603sQhaSO3/g5bY I9od9NBxaKql7TBL0xyu56GodVcSxykpxNPIpjh25JkNpJgiIRrohkcksUA2uCl6Iy kpNmNEjuyF99Wsohlgs5LUh0s/h3CLosJdZkzny0CqbwbeTw3zp1nJApmFODcX2xcT +Kte15HSc1hyqEq4KpGNW6CTWuFcNfp7BEyGd0P9s67w3ZQQ0Fk3shaVXc2HqxLT/0 IlPcJ1YD1vOHQ== From: Sasha Levin To: stable@vger.kernel.org Cc: Jiayuan Chen , Martin KaFai Lau , Jakub Sitnicki , "Matthieu Baerts (NGI0)" , Sasha Levin Subject: [PATCH 5.10.y] mptcp: Fix proto fallback detection with BPF Date: Mon, 24 Nov 2025 12:38:21 -0500 Message-ID: <20251124173821.4165452-1-sashal@kernel.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <2025112454-comic-external-4ced@gregkh> References: <2025112454-comic-external-4ced@gregkh> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Jiayuan Chen [ Upstream commit c77b3b79a92e3345aa1ee296180d1af4e7031f8f ] The sockmap feature allows bpf syscall from userspace, or based on bpf sockops, replacing the sk_prot of sockets during protocol stack processing with sockmap's custom read/write interfaces. ''' tcp_rcv_state_process() syn_recv_sock()/subflow_syn_recv_sock() tcp_init_transfer(BPF_SOCK_OPS_PASSIVE_ESTABLISHED_CB) bpf_skops_established <== sockops bpf_sock_map_update(sk) <== call bpf helper tcp_bpf_update_proto() <== update sk_prot ''' When the server has MPTCP enabled but the client sends a TCP SYN without MPTCP, subflow_syn_recv_sock() performs a fallback on the subflow, replacing the subflow sk's sk_prot with the native sk_prot. ''' subflow_syn_recv_sock() subflow_ulp_fallback() subflow_drop_ctx() mptcp_subflow_ops_undo_override() ''' Then, this subflow can be normally used by sockmap, which replaces the native sk_prot with sockmap's custom sk_prot. The issue occurs when the user executes accept::mptcp_stream_accept::mptcp_fallback_tcp_ops(). Here, it uses sk->sk_prot to compare with the native sk_prot, but this is incorrect when sockmap is used, as we may incorrectly set sk->sk_socket->ops. This fix uses the more generic sk_family for the comparison instead. Additionally, this also prevents a WARNING from occurring: result from ./scripts/decode_stacktrace.sh: ------------[ cut here ]------------ WARNING: CPU: 0 PID: 337 at net/mptcp/protocol.c:68 mptcp_stream_accept \ (net/mptcp/protocol.c:4005) Modules linked in: ... PKRU: 55555554 Call Trace: do_accept (net/socket.c:1989) __sys_accept4 (net/socket.c:2028 net/socket.c:2057) __x64_sys_accept (net/socket.c:2067) x64_sys_call (arch/x86/entry/syscall_64.c:41) do_syscall_64 (arch/x86/entry/syscall_64.c:63 arch/x86/entry/syscall_64.c:94) entry_SYSCALL_64_after_hwframe (arch/x86/entry/entry_64.S:130) RIP: 0033:0x7f87ac92b83d ---[ end trace 0000000000000000 ]--- Fixes: 0b4f33def7bb ("mptcp: fix tcp fallback crash") Signed-off-by: Jiayuan Chen Signed-off-by: Martin KaFai Lau Reviewed-by: Jakub Sitnicki Reviewed-by: Matthieu Baerts (NGI0) Cc: Link: https://patch.msgid.link/20251111060307.194196-3-jiayuan.chen@linux.dev [ applied fix to mptcp_is_tcpsk() instead of mptcp_fallback_tcp_ops() ] Signed-off-by: Sasha Levin --- net/mptcp/protocol.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/net/mptcp/protocol.c b/net/mptcp/protocol.c index 1342c31df0c40..59abf636a2e43 100644 --- a/net/mptcp/protocol.c +++ b/net/mptcp/protocol.c @@ -56,8 +56,9 @@ static struct socket *__mptcp_nmpc_socket(const struct mptcp_sock *msk) static bool mptcp_is_tcpsk(struct sock *sk) { struct socket *sock = sk->sk_socket; + unsigned short family = READ_ONCE(sk->sk_family); - if (unlikely(sk->sk_prot == &tcp_prot)) { + if (unlikely(family == AF_INET)) { /* we are being invoked after mptcp_accept() has * accepted a non-mp-capable flow: sk is a tcp_sk, * not an mptcp one. @@ -68,7 +69,7 @@ static bool mptcp_is_tcpsk(struct sock *sk) sock->ops = &inet_stream_ops; return true; #if IS_ENABLED(CONFIG_MPTCP_IPV6) - } else if (unlikely(sk->sk_prot == &tcpv6_prot)) { + } else if (unlikely(family == AF_INET6)) { sock->ops = &inet6_stream_ops; return true; #endif -- 2.51.0