From: Andrew Morton <akpm@linux-foundation.org>
To: Baoquan He <bhe@redhat.com>
Cc: Pingfan Liu <piliu@redhat.com>,
kexec@lists.infradead.org, linux-integrity@vger.kernel.org,
Mimi Zohar <zohar@linux.ibm.com>,
Roberto Sassu <roberto.sassu@huawei.com>,
Alexander Graf <graf@amazon.com>,
Steven Chen <chenste@linux.microsoft.com>,
stable@vger.kernel.org
Subject: Re: [PATCHv2 1/2] kernel/kexec: Change the prototype of kimage_map_segment()
Date: Tue, 25 Nov 2025 09:55:13 -0800 [thread overview]
Message-ID: <20251125095513.d71dcf5aca95db49008cbc25@linux-foundation.org> (raw)
In-Reply-To: <aSU2jy/ujJILHH9n@MiWiFi-R3L-srv>
On Tue, 25 Nov 2025 12:54:39 +0800 Baoquan He <bhe@redhat.com> wrote:
> On 11/24/25 at 02:16pm, Andrew Morton wrote:
> > On Thu, 6 Nov 2025 14:59:03 +0800 Pingfan Liu <piliu@redhat.com> wrote:
> >
> > > The kexec segment index will be required to extract the corresponding
> > > information for that segment in kimage_map_segment(). Additionally,
> > > kexec_segment already holds the kexec relocation destination address and
> > > size. Therefore, the prototype of kimage_map_segment() can be changed.
> >
> > Could we please have some reviewer input on thee two patches?
>
> I have some concerns about the one place of tiny code change, and the
> root cause missing in log. And Mimi sent mail to me asking why this bug
> can'e be seen on her laptop, I told her this bug can only be triggered
> on system where CMA area exists. I think these need be addressed in v3.
Great, thanks, I'll drop this version.
next prev parent reply other threads:[~2025-11-25 17:55 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-06 6:59 [PATCHv2 1/2] kernel/kexec: Change the prototype of kimage_map_segment() Pingfan Liu
2025-11-06 6:59 ` [PATCHv2 2/2] kernel/kexec: Fix IMA when allocation happens in CMA area Pingfan Liu
2025-11-06 8:01 ` Baoquan He
2025-11-06 10:01 ` Pingfan Liu
2025-11-07 1:51 ` Baoquan He
2025-11-07 5:13 ` Pingfan Liu
2025-11-07 5:25 ` Baoquan He
2025-11-07 9:00 ` Pingfan Liu
2025-11-07 9:31 ` Baoquan He
2025-11-07 9:34 ` Baoquan He
2025-11-24 22:16 ` [PATCHv2 1/2] kernel/kexec: Change the prototype of kimage_map_segment() Andrew Morton
2025-11-25 4:10 ` Pingfan Liu
2025-11-25 4:54 ` Baoquan He
2025-11-25 17:55 ` Andrew Morton [this message]
2025-11-26 1:10 ` Baoquan He
2025-11-26 1:53 ` Baoquan He
2025-11-26 2:30 ` Pingfan Liu
2025-11-26 4:47 ` Pingfan Liu
2025-12-03 4:22 ` Pingfan Liu
2025-12-03 8:06 ` Baoquan He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251125095513.d71dcf5aca95db49008cbc25@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=bhe@redhat.com \
--cc=chenste@linux.microsoft.com \
--cc=graf@amazon.com \
--cc=kexec@lists.infradead.org \
--cc=linux-integrity@vger.kernel.org \
--cc=piliu@redhat.com \
--cc=roberto.sassu@huawei.com \
--cc=stable@vger.kernel.org \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).