* [PATCH] soc: ti: k3-socinfo: fix regmap leak on probe failure
@ 2025-11-27 13:49 Johan Hovold
2025-12-01 18:02 ` Andrew Davis
0 siblings, 1 reply; 2+ messages in thread
From: Johan Hovold @ 2025-11-27 13:49 UTC (permalink / raw)
To: Nishanth Menon, Santosh Shilimkar
Cc: linux-kernel, Johan Hovold, stable, Andrew Davis
The mmio regmap allocated during probe is never freed.
Switch to using the device managed allocator so that the regmap is
released on probe failures (e.g. probe deferral) and on driver unbind.
Fixes: a5caf03188e4 ("soc: ti: k3-socinfo: Do not use syscon helper to build regmap")
Cc: stable@vger.kernel.org # 6.15
Cc: Andrew Davis <afd@ti.com>
Signed-off-by: Johan Hovold <johan@kernel.org>
---
drivers/soc/ti/k3-socinfo.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/soc/ti/k3-socinfo.c b/drivers/soc/ti/k3-socinfo.c
index 50c170a995f9..42275cb5ba1c 100644
--- a/drivers/soc/ti/k3-socinfo.c
+++ b/drivers/soc/ti/k3-socinfo.c
@@ -141,7 +141,7 @@ static int k3_chipinfo_probe(struct platform_device *pdev)
if (IS_ERR(base))
return PTR_ERR(base);
- regmap = regmap_init_mmio(dev, base, &k3_chipinfo_regmap_cfg);
+ regmap = devm_regmap_init_mmio(dev, base, &k3_chipinfo_regmap_cfg);
if (IS_ERR(regmap))
return PTR_ERR(regmap);
--
2.51.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] soc: ti: k3-socinfo: fix regmap leak on probe failure
2025-11-27 13:49 [PATCH] soc: ti: k3-socinfo: fix regmap leak on probe failure Johan Hovold
@ 2025-12-01 18:02 ` Andrew Davis
0 siblings, 0 replies; 2+ messages in thread
From: Andrew Davis @ 2025-12-01 18:02 UTC (permalink / raw)
To: Johan Hovold, Nishanth Menon, Santosh Shilimkar; +Cc: linux-kernel, stable
On 11/27/25 7:49 AM, Johan Hovold wrote:
> The mmio regmap allocated during probe is never freed.
>
> Switch to using the device managed allocator so that the regmap is
> released on probe failures (e.g. probe deferral) and on driver unbind.
>
> Fixes: a5caf03188e4 ("soc: ti: k3-socinfo: Do not use syscon helper to build regmap")
> Cc: stable@vger.kernel.org # 6.15
> Cc: Andrew Davis <afd@ti.com>
> Signed-off-by: Johan Hovold <johan@kernel.org>
> ---
Acked-by: Andrew Davis <afd@ti.com>
> drivers/soc/ti/k3-socinfo.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/soc/ti/k3-socinfo.c b/drivers/soc/ti/k3-socinfo.c
> index 50c170a995f9..42275cb5ba1c 100644
> --- a/drivers/soc/ti/k3-socinfo.c
> +++ b/drivers/soc/ti/k3-socinfo.c
> @@ -141,7 +141,7 @@ static int k3_chipinfo_probe(struct platform_device *pdev)
> if (IS_ERR(base))
> return PTR_ERR(base);
>
> - regmap = regmap_init_mmio(dev, base, &k3_chipinfo_regmap_cfg);
> + regmap = devm_regmap_init_mmio(dev, base, &k3_chipinfo_regmap_cfg);
> if (IS_ERR(regmap))
> return PTR_ERR(regmap);
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-12-01 18:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-11-27 13:49 [PATCH] soc: ti: k3-socinfo: fix regmap leak on probe failure Johan Hovold
2025-12-01 18:02 ` Andrew Davis
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).