From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 34CE0253958; Mon, 1 Dec 2025 11:27:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764588436; cv=none; b=cFfT+TubjQPvqanzsI4v5tFmdpLU+eWLaDxZJ9fJvpAMb6HkHC8exYYqv99DEFHO0cIFwWAj8a6qoOsyWJOr5in8fOrbvPvMUpFSF48DJAD7oKHviTvO0ZLO8dtYv36NB9MuMC0I18WVyK7WSfOfpU0Bw9yBgTID7OEo/LBVHa8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764588436; c=relaxed/simple; bh=Xy3ArBO5FRc0O2NLfu4jv63o3z8D9RapLCrc7rGBCPQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=S0Hp/wTwRR26uyGLFluAWFuZf+OBBzJFMppLW/MlmVukiXnkRe570XBxaekQzxgfkNVeOUoPG9kuAR8/KydMevD3X7TqDVkOs6FCFPn9G1awkq1WdFjBcGjc6akpVOIn7JL5QOYCFgsqyuGEmfVLxaahozsg/HcBxd1D0l9+x8k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=RimAtBHe; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="RimAtBHe" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B653BC4CEF1; Mon, 1 Dec 2025 11:27:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1764588436; bh=Xy3ArBO5FRc0O2NLfu4jv63o3z8D9RapLCrc7rGBCPQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=RimAtBHeo5Dq86nfv67pmWYAOOsN/o4RWMNPnCsVCVihCAp/TQQj4Pl6P2v/geBS5 qlT5Dvcw5sdZeQndr2+ZEc8ILrr2XyjneAhhVvOtHsKaNGYxpmCPJSn66GJauX1zRs egzwP3QzcMQlrqixD4CHnnuR3448lE99UEnL1FPA= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Emanuele Ghidoli , Andrew Lunn , Jakub Kicinski , Sasha Levin Subject: [PATCH 5.4 015/187] net: phy: dp83867: Disable EEE support as not implemented Date: Mon, 1 Dec 2025 12:22:03 +0100 Message-ID: <20251201112241.801238120@linuxfoundation.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251201112241.242614045@linuxfoundation.org> References: <20251201112241.242614045@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Emanuele Ghidoli [ Upstream commit 84a905290cb4c3d9a71a9e3b2f2e02e031e7512f ] While the DP83867 PHYs report EEE capability through their feature registers, the actual hardware does not support EEE (see Links). When the connected MAC enables EEE, it causes link instability and communication failures. The issue is reproducible with a iMX8MP and relevant stmmac ethernet port. Since the introduction of phylink-managed EEE support in the stmmac driver, EEE is now enabled by default, leading to issues on systems using the DP83867 PHY. Call phy_disable_eee during phy initialization to prevent EEE from being enabled on DP83867 PHYs. Link: https://e2e.ti.com/support/interface-group/interface/f/interface-forum/1445244/dp83867ir-dp83867-disable-eee-lpi Link: https://e2e.ti.com/support/interface-group/interface/f/interface-forum/658638/dp83867ir-eee-energy-efficient-ethernet Fixes: 2a10154abcb7 ("net: phy: dp83867: Add TI dp83867 phy") Cc: stable@vger.kernel.org Signed-off-by: Emanuele Ghidoli Reviewed-by: Andrew Lunn Link: https://patch.msgid.link/20251023144857.529566-1-ghidoliemanuele@gmail.com Signed-off-by: Jakub Kicinski [ replaced phy_disable_eee() call with direct eee_broken_modes assignment ] Signed-off-by: Sasha Levin Signed-off-by: Greg Kroah-Hartman --- drivers/net/phy/dp83867.c | 6 ++++++ 1 file changed, 6 insertions(+) --- a/drivers/net/phy/dp83867.c +++ b/drivers/net/phy/dp83867.c @@ -337,6 +337,12 @@ static int dp83867_config_init(struct ph return ret; } + /* Although the DP83867 reports EEE capability through the + * MDIO_PCS_EEE_ABLE and MDIO_AN_EEE_ADV registers, the feature + * is not actually implemented in hardware. + */ + phydev->eee_broken_modes = MDIO_EEE_100TX | MDIO_EEE_1000T; + if (phy_interface_is_rgmii(phydev)) { val = phy_read(phydev, MII_DP83867_PHYCTRL); if (val < 0)