From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7B8773081C6; Mon, 1 Dec 2025 11:27:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764588471; cv=none; b=tl0c0McbWo2NtfFu3po740I24aDPKlEIBbSkZZ+i4m1N3XYsvNSBRU7Mc2PafYAb6p/lFRmtF4PbERjD1sEaMR+O35UqMJc5JFVR4Va3romBfQOS1qVbo0zChJ2eHJ6HamNdS9epUPEcsfRWHNxVghdI6owMfa8kZb3VsBpN7jo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764588471; c=relaxed/simple; bh=ZWNL/CkZt1hN6wwCLr4Dx1LypMH7sys0tUHi0F8MxfU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Lt8G9YMuG5nnjX7OduI9q9Ythysqikx+UkmTeqVbGTTwz2+ZLHSidI3d+WIX7pdHqs6HPyLQagim8lpsoPwgUqvVNtY+MKUunF2JLcvHQPzdMjUGzuZ26CddnTTCgug5SFoKIriBBgscnoQ13Sa4CScCj21v/kEwwl7q8ujPhmk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=pGHtM9Qi; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="pGHtM9Qi" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 94BBEC4CEF1; Mon, 1 Dec 2025 11:27:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1764588470; bh=ZWNL/CkZt1hN6wwCLr4Dx1LypMH7sys0tUHi0F8MxfU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=pGHtM9QiXWTAYFW9cGXD2tJszCJ+BvqwjuDk6oVhok5ya/J1ZPbD6NJe43YrRyl9W qQl03s4om09nM/y6674DAT+kc+5kMVchryndiuWiv79TUUTHcF+bczIdbWiWJ+IDlB i+m4pjGcwpTNv6ACx6V2X6QlATrZjYn0KYKmtoes= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, raub camaioni , Sasha Levin Subject: [PATCH 5.4 060/187] usb: gadget: f_ncm: Fix MAC assignment NCM ethernet Date: Mon, 1 Dec 2025 12:22:48 +0100 Message-ID: <20251201112243.410369608@linuxfoundation.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251201112241.242614045@linuxfoundation.org> References: <20251201112241.242614045@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: raub camaioni [ Upstream commit 956606bafb5fc6e5968aadcda86fc0037e1d7548 ] This fix is already present in f_ecm.c and was never propagated to f_ncm.c When creating multiple NCM ethernet devices on a composite usb gadget device each MAC address on the HOST side will be identical. Having the same MAC on different network interfaces is bad. This fix updates the MAC address inside the ncm_strings_defs global during the ncm_bind call. This ensures each device has a unique MAC. In f_ecm.c ecm_string_defs is updated in the same way. The defunct MAC assignment in ncm_alloc has been removed. Signed-off-by: raub camaioni Link: https://lore.kernel.org/r/20250815131358.1047525-1-raubcameo@gmail.com Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/usb/gadget/function/f_ncm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/usb/gadget/function/f_ncm.c b/drivers/usb/gadget/function/f_ncm.c index ca50257b95384..b1e5693373820 100644 --- a/drivers/usb/gadget/function/f_ncm.c +++ b/drivers/usb/gadget/function/f_ncm.c @@ -1472,6 +1472,8 @@ static int ncm_bind(struct usb_configuration *c, struct usb_function *f) ncm_opts->bound = true; + ncm_string_defs[1].s = ncm->ethaddr; + us = usb_gstrings_attach(cdev, ncm_strings, ARRAY_SIZE(ncm_string_defs)); if (IS_ERR(us)) { @@ -1735,7 +1737,6 @@ static struct usb_function *ncm_alloc(struct usb_function_instance *fi) mutex_unlock(&opts->lock); return ERR_PTR(-EINVAL); } - ncm_string_defs[STRING_MAC_IDX].s = ncm->ethaddr; spin_lock_init(&ncm->lock); ncm_reset_values(ncm); -- 2.51.0