From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D9EAF2F25F7; Mon, 1 Dec 2025 11:29:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764588563; cv=none; b=P54Lz2KH8cvwOQTmncW/RlvgDWYLFeTzYyg4OuVkz/X3rIQNUshg4QhO7FfiOFHN3D6qneftR4Sh+b04W28ddLgrOksYJzc82JEPLBw1V72V0MhZFxNOJHfto/Q1XUhl+W8BRhqiFE4KRHopx5e8XbXpiK6JGqT/nAIioBf1isc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764588563; c=relaxed/simple; bh=u+q3w7gnv5owG8qFa3kTyharWw+lNLKIjBf3zUriMNM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=rbAEFcA/xg5N7cWHZ7Ra94HdMUITJSXhQw4fbXHclgLrdi45W+Ntk5jgxu8WgTldk3mZH/tsN/Z1iRDq55mQWScVFtmRW+fZREbph6BP+3gO9FBCMGk38BmdaRg5A92SxXSN0NfQgESdWfS0cipG9sGsi+OFjHkRccDiZMC8YTU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=sRak3e8n; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="sRak3e8n" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 64065C4CEF1; Mon, 1 Dec 2025 11:29:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1764588563; bh=u+q3w7gnv5owG8qFa3kTyharWw+lNLKIjBf3zUriMNM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=sRak3e8nmYTv9GWhycGBPdg4wX2dfyX5uWp7WThwpMxAagZeYjQRa84V0+B6NQfo8 5Wx8AsY/9mQyf/m3QVy9tFM8UMnpvWo3z3jzZGN8LXW4K+o6iSAAZdC3JGs1lPOoxX z4b+dfzKMdOZT7D/ABCRwX6fOFKvh+rN5alenwTU= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, syzbot , Tetsuo Handa , Dave Kleikamp , Sasha Levin Subject: [PATCH 5.4 093/187] jfs: Verify inode mode when loading from disk Date: Mon, 1 Dec 2025 12:23:21 +0100 Message-ID: <20251201112244.602446059@linuxfoundation.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251201112241.242614045@linuxfoundation.org> References: <20251201112241.242614045@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Tetsuo Handa [ Upstream commit 7a5aa54fba2bd591b22b9b624e6baa9037276986 ] The inode mode loaded from corrupted disk can be invalid. Do like what commit 0a9e74051313 ("isofs: Verify inode mode when loading from disk") does. Reported-by: syzbot Closes: https://syzkaller.appspot.com/bug?extid=895c23f6917da440ed0d Signed-off-by: Tetsuo Handa Signed-off-by: Dave Kleikamp Signed-off-by: Sasha Levin --- fs/jfs/inode.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/fs/jfs/inode.c b/fs/jfs/inode.c index 6d353fbe67c04..0fb502ed7273c 100644 --- a/fs/jfs/inode.c +++ b/fs/jfs/inode.c @@ -59,9 +59,15 @@ struct inode *jfs_iget(struct super_block *sb, unsigned long ino) */ inode->i_link[inode->i_size] = '\0'; } - } else { + } else if (S_ISCHR(inode->i_mode) || S_ISBLK(inode->i_mode) || + S_ISFIFO(inode->i_mode) || S_ISSOCK(inode->i_mode)) { inode->i_op = &jfs_file_inode_operations; init_special_inode(inode, inode->i_mode, inode->i_rdev); + } else { + printk(KERN_DEBUG "JFS: Invalid file type 0%04o for inode %lu.\n", + inode->i_mode, inode->i_ino); + iget_failed(inode); + return ERR_PTR(-EIO); } unlock_new_inode(inode); return inode; -- 2.51.0