From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8FD3E258ED1; Mon, 1 Dec 2025 11:32:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764588746; cv=none; b=dEos2dUffTk44iPd06MxRewxGNc4e0UD74+t4OT6qcdk+els3zoTLVkIuD4oUy7wEhJgxDpG0YCJenkr/dAOzNiXH1oIS0LyiTpv0a5gd8i0TbKWgDZDWvbqcPgRcmY70uVgkNRPWLVHfzC6ecwd64v+AbCQ96RFcWi0iZBWj1g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764588746; c=relaxed/simple; bh=AwMoywOqO4X71zuUt/qwOd36Ss3OrvIcpYJPmF9R1K4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=lMqBzmQxfTDzaIiMBnFK2XaxSfuddsHjou6pNbKEfkmmNTS9Y9bbNh4tAoHy+v3bb0DTawdJUEgKN+YyiHxwqXBAwS/G7DMHWU64sABL2RvdKbex8u+X5wrZj12wxHggzB7tRTsVZEgR8oGSU46TzVqnh4/8fjuill4MO8jkFW4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=cOl6MDaX; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="cOl6MDaX" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 12279C4CEF1; Mon, 1 Dec 2025 11:32:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1764588746; bh=AwMoywOqO4X71zuUt/qwOd36Ss3OrvIcpYJPmF9R1K4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=cOl6MDaX+9RFci3gF9Bv61mv1Y8Br8A64yYlDF8JwMaF8btYDfSgKNPR2vEwFElDa ECwVYbSQvBgekNt+R/O7jGG1mtSApcUDN9tgItNokiG1fAs3RYimDJI5PVpzW+4mtV 1pHuCwDIQdJZab6gn4STDESy1a1ICg9H5fjUditU= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Zilin Guan , "Steven Rostedt (Google)" , Sasha Levin Subject: [PATCH 5.4 123/187] tracing: Fix memory leaks in create_field_var() Date: Mon, 1 Dec 2025 12:23:51 +0100 Message-ID: <20251201112245.672231051@linuxfoundation.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251201112241.242614045@linuxfoundation.org> References: <20251201112241.242614045@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Zilin Guan [ Upstream commit 80f0d631dcc76ee1b7755bfca1d8417d91d71414 ] The function create_field_var() allocates memory for 'val' through create_hist_field() inside parse_atom(), and for 'var' through create_var(), which in turn allocates var->type and var->var.name internally. Simply calling kfree() to release these structures will result in memory leaks. Use destroy_hist_field() to properly free 'val', and explicitly release the memory of var->type and var->var.name before freeing 'var' itself. Link: https://patch.msgid.link/20251106120132.3639920-1-zilin@seu.edu.cn Fixes: 02205a6752f22 ("tracing: Add support for 'field variables'") Signed-off-by: Zilin Guan Signed-off-by: Steven Rostedt (Google) Signed-off-by: Sasha Levin --- kernel/trace/trace_events_hist.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/kernel/trace/trace_events_hist.c b/kernel/trace/trace_events_hist.c index 1ede6d41ab8da..21d0731874448 100644 --- a/kernel/trace/trace_events_hist.c +++ b/kernel/trace/trace_events_hist.c @@ -3634,14 +3634,16 @@ static struct field_var *create_field_var(struct hist_trigger_data *hist_data, var = create_var(hist_data, file, field_name, val->size, val->type); if (IS_ERR(var)) { hist_err(tr, HIST_ERR_VAR_CREATE_FIND_FAIL, errpos(field_name)); - kfree(val); + destroy_hist_field(val, 0); ret = PTR_ERR(var); goto err; } field_var = kzalloc(sizeof(struct field_var), GFP_KERNEL); if (!field_var) { - kfree(val); + destroy_hist_field(val, 0); + kfree_const(var->type); + kfree(var->var.name); kfree(var); ret = -ENOMEM; goto err; -- 2.51.0