From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C4624255F2D; Mon, 1 Dec 2025 11:33:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764588819; cv=none; b=XTD+sFhtE/9RsgwVPM/lj9ibmfRN7aC9izLTLWpPAPCWkYnLGyvXBBjpsBrAirDxgzggYbU5AZqO4Nq5dSvpnbQqqJI7gFL0hVmFwHryH3F2SQEsR+KNYimMDfuRhZPd+VVdMiesti/akbfdjhOwfnMZp0tFLn7fpWq5OjATyqs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764588819; c=relaxed/simple; bh=YsEFsF09qHiTUuyYZ59G/u4uEGAAPTHVp6s8BtYAQH4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=a3y2WC1zamkmc69ZVCYG4dsQ+ktu/I7vt5HO9jwb65mYBckirnm+ftd79DGOZbZrEY7M05Mfx/c5OWQTxUkOLk7O3VJHt45oc3wOrxEXigJf1axxVJkpwL+MGS9uQs/wraEtcHiPOZInKwXQlO8byMco1ChhjXA22LCpk4XWPD0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=g9zIinDF; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="g9zIinDF" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4F761C4CEF1; Mon, 1 Dec 2025 11:33:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1764588819; bh=YsEFsF09qHiTUuyYZ59G/u4uEGAAPTHVp6s8BtYAQH4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=g9zIinDFVcJG3IeIBXO48WHyKRjr6EqVEi/S2pgZP9oREkyAffEAkfALYMW2dwkiB zhb0HddfTDIeXmBONfTkVWUVwx521sgz6vkz4/96Qpp1nMCUKws3MPELbQQISfTCwa Tw0txP7+/5fANOpxnYsFCkXMio68uzJrYo3clpFg= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Hans de Goede , Mark Brown Subject: [PATCH 5.4 155/187] spi: Try to get ACPI GPIO IRQ earlier Date: Mon, 1 Dec 2025 12:24:23 +0100 Message-ID: <20251201112246.816640183@linuxfoundation.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251201112241.242614045@linuxfoundation.org> References: <20251201112241.242614045@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Hans de Goede commit 3cd2018e15b3d66d2187d92867e265f45ad79e6f upstream. Since commit d24cfee7f63d ("spi: Fix acpi deferred irq probe"), the acpi_dev_gpio_irq_get() call gets delayed till spi_probe() is called on the SPI device. If there is no driver for the SPI device then the move to spi_probe() results in acpi_dev_gpio_irq_get() never getting called. This may cause problems by leaving the GPIO pin floating because this call is responsible for setting up the GPIO pin direction and/or bias according to the values from the ACPI tables. Re-add the removed acpi_dev_gpio_irq_get() in acpi_register_spi_device() to ensure the GPIO pin is always correctly setup, while keeping the acpi_dev_gpio_irq_get() call added to spi_probe() to deal with -EPROBE_DEFER returns caused by the GPIO controller not having a driver yet. Link: https://bbs.archlinux.org/viewtopic.php?id=302348 Fixes: d24cfee7f63d ("spi: Fix acpi deferred irq probe") Cc: stable@vger.kernel.org Signed-off-by: Hans de Goede Link: https://patch.msgid.link/20251102190921.30068-1-hansg@kernel.org Signed-off-by: Mark Brown Signed-off-by: Greg Kroah-Hartman --- drivers/spi/spi.c | 10 ++++++++++ 1 file changed, 10 insertions(+) --- a/drivers/spi/spi.c +++ b/drivers/spi/spi.c @@ -2055,6 +2055,16 @@ static acpi_status acpi_register_spi_dev acpi_set_modalias(adev, acpi_device_hid(adev), spi->modalias, sizeof(spi->modalias)); + /* + * This gets re-tried in spi_probe() for -EPROBE_DEFER handling in case + * the GPIO controller does not have a driver yet. This needs to be done + * here too, because this call sets the GPIO direction and/or bias. + * Setting these needs to be done even if there is no driver, in which + * case spi_probe() will never get called. + */ + if (spi->irq < 0) + spi->irq = acpi_dev_gpio_irq_get(adev, 0); + acpi_device_set_enumerated(adev); adev->power.flags.ignore_parent = true;