From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 55AFD26C39B; Mon, 1 Dec 2025 11:32:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764588769; cv=none; b=H4CyzZ4YE8+Q0dC4X9e8CVi+dvSJx7gNG/IrsXNqq8iphFuogC7UwkyED/EZtAGgoACyTc8kmdsCeaSRz0jgwgNpwGR+ACUtUsaGFG1d+jNTM7YIBwwZDpcFI8hrKeXCph47fi9ukfNwsDAoSu5kWyMm7g+7sJkVACFnEK7m2Yk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764588769; c=relaxed/simple; bh=LWswjR/tT18I4FeBks2Bi5NhUqFBHbzLBjPUFh+Qy2E=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=HtzYK3laLuimiYlAdDBUzRj/jth1giqqy0NcYtw216T/kvpQvDylFg5VN7DECyKQQKkOiITFRGbEhYvxnSUzOPT/5D0d/jfQC9rXEXyW00AkSEJD7qJxCUoZjuNWno6gjTDehU05MRL5ZNEDTG0nb713KR14uyD972GL8CWp7J4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=EW4fOPDw; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="EW4fOPDw" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D5117C4CEF1; Mon, 1 Dec 2025 11:32:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1764588769; bh=LWswjR/tT18I4FeBks2Bi5NhUqFBHbzLBjPUFh+Qy2E=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=EW4fOPDww5C7Kqz69PH1CZo6hTI4nKTUP/Nz3h49IYsYMaXq9HGN0IjrnXTeeOFXA dTklStyz/5UgYoLahgebasOGjYwef7vzxLhckw7B+vT2IHGlzLH1DisWWHIVYBSuig q7pg5rwlMwjRssl6afi/mgXR1whrFwCqiriPiPHM= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Zilin Guan , Ido Schimmel , Jakub Kicinski , Sasha Levin Subject: [PATCH 5.4 165/187] mlxsw: spectrum: Fix memory leak in mlxsw_sp_flower_stats() Date: Mon, 1 Dec 2025 12:24:33 +0100 Message-ID: <20251201112247.173925294@linuxfoundation.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251201112241.242614045@linuxfoundation.org> References: <20251201112241.242614045@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Zilin Guan [ Upstream commit 407a06507c2358554958e8164dc97176feddcafc ] The function mlxsw_sp_flower_stats() calls mlxsw_sp_acl_ruleset_get() to obtain a ruleset reference. If the subsequent call to mlxsw_sp_acl_rule_lookup() fails to find a rule, the function returns an error without releasing the ruleset reference, causing a memory leak. Fix this by using a goto to the existing error handling label, which calls mlxsw_sp_acl_ruleset_put() to properly release the reference. Fixes: 7c1b8eb175b69 ("mlxsw: spectrum: Add support for TC flower offload statistics") Signed-off-by: Zilin Guan Reviewed-by: Ido Schimmel Link: https://patch.msgid.link/20251112052114.1591695-1-zilin@seu.edu.cn Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- drivers/net/ethernet/mellanox/mlxsw/spectrum_flower.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum_flower.c b/drivers/net/ethernet/mellanox/mlxsw/spectrum_flower.c index 498de6ef68705..4eeebcb50ab68 100644 --- a/drivers/net/ethernet/mellanox/mlxsw/spectrum_flower.c +++ b/drivers/net/ethernet/mellanox/mlxsw/spectrum_flower.c @@ -542,8 +542,10 @@ int mlxsw_sp_flower_stats(struct mlxsw_sp *mlxsw_sp, return -EINVAL; rule = mlxsw_sp_acl_rule_lookup(mlxsw_sp, ruleset, f->cookie); - if (!rule) - return -EINVAL; + if (!rule) { + err = -EINVAL; + goto err_rule_get_stats; + } err = mlxsw_sp_acl_rule_get_stats(mlxsw_sp, rule, &packets, &bytes, &lastuse); -- 2.51.0