From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4505C303C86; Wed, 3 Dec 2025 15:31:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764775889; cv=none; b=AIPZGSMKbaem9kTh4sBfeJg4WN0VfyiGK4bkHq8h1cpj6J9d5V+z0Pb8Hid+IjTzFD47EL3QCivC9hwqCHHTH+PCO6MVxpKl5NB5F4fD/qEL1B0xkxlbm41Yad8ehmLGTWLei9CxzaBMNjtCugHRig4jWL74//I6SEO0lPcUt+g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764775889; c=relaxed/simple; bh=eSucpLjJUXocBC5lIc4nxxkVaFMkjwviLbeAwtC7KSc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=nHzEEgsaGWN/fD9sOGeccn+pIEFJfZfeSuLOHnBLnhgnshs6UneJZbROtxQHEODZMH5pybV+w2jYl0TURyAAh0Wv6THjWNeRwl4ZPSUjUSNeto+3ozV3ReRWwMlU5mYzWUbQSgFrimX36/60Vk3KppHgNSSfSYIJ15xv25Qd7+Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=CNPeHdMg; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="CNPeHdMg" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 474F4C4CEF5; Wed, 3 Dec 2025 15:31:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1764775888; bh=eSucpLjJUXocBC5lIc4nxxkVaFMkjwviLbeAwtC7KSc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=CNPeHdMgK2/0kFlSPl+wCr7zstKd8bT0CtV9mgITKz3L6uI0REFOFFmOBOV1Xe8DG JzjMwnCSDd5aLrvXDqCGklKqXke52aAfRpcEn1owodpoC/FIZBHHo1tMIBNZRM8Vy3 9jMM0vDP6jHRONYYA3ekNICbgdau8LLjoiF0kMnM= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Sam Sun , Lizhi Xu , Jakub Kicinski , Sasha Levin Subject: [PATCH 5.10 018/300] usbnet: Prevents free active kevent Date: Wed, 3 Dec 2025 16:23:42 +0100 Message-ID: <20251203152401.132166794@linuxfoundation.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251203152400.447697997@linuxfoundation.org> References: <20251203152400.447697997@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Lizhi Xu [ Upstream commit 420c84c330d1688b8c764479e5738bbdbf0a33de ] The root cause of this issue are: 1. When probing the usbnet device, executing usbnet_link_change(dev, 0, 0); put the kevent work in global workqueue. However, the kevent has not yet been scheduled when the usbnet device is unregistered. Therefore, executing free_netdev() results in the "free active object (kevent)" error reported here. 2. Another factor is that when calling usbnet_disconnect()->unregister_netdev(), if the usbnet device is up, ndo_stop() is executed to cancel the kevent. However, because the device is not up, ndo_stop() is not executed. The solution to this problem is to cancel the kevent before executing free_netdev(). Fixes: a69e617e533e ("usbnet: Fix linkwatch use-after-free on disconnect") Reported-by: Sam Sun Closes: https://syzkaller.appspot.com/bug?extid=8bfd7bcc98f7300afb84 Signed-off-by: Lizhi Xu Link: https://patch.msgid.link/20251022024007.1831898-1-lizhi.xu@windriver.com Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- drivers/net/usb/usbnet.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/usb/usbnet.c b/drivers/net/usb/usbnet.c index ac439f9ccfd46..9ac9fbdad5c08 100644 --- a/drivers/net/usb/usbnet.c +++ b/drivers/net/usb/usbnet.c @@ -1597,6 +1597,8 @@ void usbnet_disconnect (struct usb_interface *intf) net = dev->net; unregister_netdev (net); + cancel_work_sync(&dev->kevent); + while ((urb = usb_get_from_anchor(&dev->deferred))) { dev_kfree_skb(urb->context); kfree(urb->sg); -- 2.51.0