Re: Patch "media: ov02c10: Fix default vertical flip" has been added to the 6.18-stable tree

Re: Patch "media: ov02c10: Fix default vertical flip" has been added to the 6.18-stable tree

[Hans de Goede]

Hi Sasha,

On 13-Dec-25 10:35, Sasha Levin wrote:
> This is a note to let you know that I've just added the patch titled
> 
>     media: ov02c10: Fix default vertical flip

This fix is incomplete, leading to wrong colors and it causes
the image to be upside down on some Dell XPS models where it
currently is the right way up.

There is a series of fixes which applies on top of this to
fix both issues:

https://lore.kernel.org/linux-media/20251210112436.167212-1-johannes.goede@oss.qualcomm.com/

For now (without the fixes on top) we are better of not adding
this patch to the stable series. Can you drop this patch
please?

Same for 6.17 and other stable series.

Regards,

Hans






> 
> to the 6.18-stable tree which can be found at:
>     http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
> 
> The filename of the patch is:
>      media-ov02c10-fix-default-vertical-flip.patch
> and it can be found in the queue-6.18 subdirectory.
> 
> If you, or anyone else, feels it should not be added to the stable tree,
> please let <stable@vger.kernel.org> know about it.
> 
> 
> 
> commit 14cc4474799a595caeccdb8fdf2ca4b867cef972
> Author: Sebastian Reichel <sre@kernel.org>
> Date:   Wed Aug 20 02:13:19 2025 +0200
> 
>     media: ov02c10: Fix default vertical flip
>     
>     [ Upstream commit d5ebe3f7d13d4cee3ff7e718de23564915aaf163 ]
>     
>     The driver right now defaults to setting the vertical flip bit. This
>     conflicts with proper handling of the rotation property defined in
>     ACPI or device tree, so drop the VFLIP bit. It should be handled via
>     V4L2_CID_VFLIP instead.
>     
>     Reported-by: Frederic Stuyk <fstuyk@runbox.com>
>     Closes: https://lore.kernel.org/all/b6df9ae7-ea9f-4e5a-8065-5b130f534f37@runbox.com/
>     Fixes: 44f89010dae0 ("media: i2c: Add Omnivision OV02C10 sensor driver")
>     Signed-off-by: Sebastian Reichel <sre@kernel.org>
>     Reviewed-by: Bryan O'Donoghue <bod@kernel.org>
>     Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
>     Signed-off-by: Hans Verkuil <hverkuil+cisco@kernel.org>
>     Signed-off-by: Sasha Levin <sashal@kernel.org>
> 

> diff --git a/drivers/media/i2c/ov02c10.c b/drivers/media/i2c/ov02c10.c
> index 8c4d85dc7922e..8e22ff446b0c4 100644
> --- a/drivers/media/i2c/ov02c10.c
> +++ b/drivers/media/i2c/ov02c10.c
> @@ -174,7 +174,7 @@ static const struct reg_sequence sensor_1928x1092_30fps_setting[] = {
>  	{0x3816, 0x01},
>  	{0x3817, 0x01},
>  
> -	{0x3820, 0xb0},
> +	{0x3820, 0xa0},
>  	{0x3821, 0x00},
>  	{0x3822, 0x80},
>  	{0x3823, 0x08},

Re: Patch "media: ov02c10: Fix default vertical flip" has been added to the 6.18-stable tree

[Greg KH]

On Sat, Dec 13, 2025 at 12:52:07PM +0100, Hans de Goede wrote:
> Hi Sasha,
> 
> On 13-Dec-25 10:35, Sasha Levin wrote:
> > This is a note to let you know that I've just added the patch titled
> > 
> >     media: ov02c10: Fix default vertical flip
> 
> This fix is incomplete, leading to wrong colors and it causes
> the image to be upside down on some Dell XPS models where it
> currently is the right way up.
> 
> There is a series of fixes which applies on top of this to
> fix both issues:
> 
> https://lore.kernel.org/linux-media/20251210112436.167212-1-johannes.goede@oss.qualcomm.com/
> 
> For now (without the fixes on top) we are better of not adding
> this patch to the stable series. Can you drop this patch
> please?

Now dropped from both queues, thanks.

greg k-h