From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 376E73644CB; Tue, 16 Dec 2025 12:09:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765886969; cv=none; b=CZfYQ+PtE6UF0Sjsd6CYufuynsiZElhf/HmhOfBAnENvmh1IF94wfaOB/MQqX/A/0s5jXocN4iqPVG29d7pMC3YtbTHeQgLOoRUZls7z8Cs34cKeMgjepvtCthDUy/SzqZcDJ0TazUjgk8ZKQyGjuaLE93hY5pzW0fpdTsMqOZE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765886969; c=relaxed/simple; bh=emF6TvkpEjSebWXPiPI2renPbVvaY3lmjFT0gLdK5R0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=RHMcIy1W/jIlBW1V+dBAjjZcN0LYrEH9rZ7N6vFDynPkWyqdToh+WUL0vxgvHnzh/xKk1e08BMrbSFPhCbBmUgwucllwW9vQKo5deu1h3tnP2SiRemoJn/YL99P3AfOCzsRD8ejDEOLyv5ZVOhW3J+iSrfo02XKEWfdE1lWhn80= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=Y+qs92pr; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="Y+qs92pr" Received: by smtp.kernel.org (Postfix) with ESMTPSA id AC3FBC4CEF1; Tue, 16 Dec 2025 12:09:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1765886969; bh=emF6TvkpEjSebWXPiPI2renPbVvaY3lmjFT0gLdK5R0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Y+qs92pr5Ni294UPYHkDtmIwtBq8hHbaCGt8c699zfXSxtiDC9xgFOAt6N9nmuBHc DQeAZnMx7mEGT+rUWlcHO3m7TFZ6TsKGzlmU6zuiEs7c79mdWYHNm+TwlVh+J0nww8 Ut0o/09xN0vrpW1vOp/Q65v3BKsJmPI+6yxptOcI= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Haotian Zhang , Konrad Dybcio , Bjorn Andersson , Sasha Levin Subject: [PATCH 6.18 087/614] soc: qcom: gsbi: fix double disable caused by devm Date: Tue, 16 Dec 2025 12:07:34 +0100 Message-ID: <20251216111404.474716962@linuxfoundation.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251216111401.280873349@linuxfoundation.org> References: <20251216111401.280873349@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.18-stable review patch. If anyone has any objections, please let me know. ------------------ From: Haotian Zhang [ Upstream commit 2286e18e3937c69cc103308a8c1d4898d8a7b04f ] In the commit referenced by the Fixes tag, devm_clk_get_enabled() was introduced to replace devm_clk_get() and clk_prepare_enable(). While the clk_disable_unprepare() call in the error path was correctly removed, the one in the remove function was overlooked, leading to a double disable issue. Remove the redundant clk_disable_unprepare() call from gsbi_remove() to fix this issue. Since all resources are now managed by devres and will be automatically released, the remove function serves no purpose and can be deleted entirely. Fixes: 489d7a8cc286 ("soc: qcom: use devm_clk_get_enabled() in gsbi_probe()") Signed-off-by: Haotian Zhang Reviewed-by: Konrad Dybcio Link: https://lore.kernel.org/stable/20251020160215.523-1-vulab%40iscas.ac.cn Link: https://lore.kernel.org/r/20251020160215.523-1-vulab@iscas.ac.cn Signed-off-by: Bjorn Andersson Signed-off-by: Sasha Levin --- drivers/soc/qcom/qcom_gsbi.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/drivers/soc/qcom/qcom_gsbi.c b/drivers/soc/qcom/qcom_gsbi.c index 8f1158e0c6313..a25d1de592f06 100644 --- a/drivers/soc/qcom/qcom_gsbi.c +++ b/drivers/soc/qcom/qcom_gsbi.c @@ -212,13 +212,6 @@ static int gsbi_probe(struct platform_device *pdev) return of_platform_populate(node, NULL, NULL, &pdev->dev); } -static void gsbi_remove(struct platform_device *pdev) -{ - struct gsbi_info *gsbi = platform_get_drvdata(pdev); - - clk_disable_unprepare(gsbi->hclk); -} - static const struct of_device_id gsbi_dt_match[] = { { .compatible = "qcom,gsbi-v1.0.0", }, { }, @@ -232,7 +225,6 @@ static struct platform_driver gsbi_driver = { .of_match_table = gsbi_dt_match, }, .probe = gsbi_probe, - .remove = gsbi_remove, }; module_platform_driver(gsbi_driver); -- 2.51.0